fix: code lint

Author: NGPixel

.gitignore

@@ -14,6 +14,7 @@ npm/node_modules
 .npm
 .node_repl_history
 npm-debug.log*
+.yarn
 
 # Generated assets
 /assets
@@ -41,6 +42,7 @@ server/views/setup.pug
 
 # Test results
 test-results/
+.scannerwork
 
 # Localization Resources
 /server/locales/**/*.yml

client/components/common/search-results.vue

@@ -55,7 +55,7 @@
 
 <script>
 import _ from 'lodash'
-import { get, sync } from 'vuex-pathify'
+import { sync } from 'vuex-pathify'
 import { OrbitSpinner } from 'epic-spinners'
 
 import searchPagesQuery from 'gql/common/common-pages-query-search.gql'
@@ -105,14 +105,6 @@ export default {
       }
     }
   },
-  methods: {
-    setSearchTerm(term) {
-      this.search = term
-    },
-    goToPage(item) {
-      window.location.assign(`/${item.locale}/${item.path}`)
-    }
-  },
   mounted() {
     this.$root.$on('searchMove', (dir) => {
       this.cursor += (dir === 'up' ? -1 : 1)
@@ -130,6 +122,14 @@ export default {
       }
     })
   },
+  methods: {
+    setSearchTerm(term) {
+      this.search = term
+    },
+    goToPage(item) {
+      window.location.assign(`/${item.locale}/${item.path}`)
+    }
+  },
   apollo: {
     response: {
       query: searchPagesQuery,

client/components/register.vue

@@ -98,7 +98,6 @@
 /* global siteConfig */
 
 import _ from 'lodash'
-import Cookies from 'js-cookie'
 import validate from 'validate.js'
 import PasswordStrength from './common/password-strength.vue'
 
@@ -134,7 +133,6 @@ export default {
     this.isShown = true
     this.$nextTick(() => {
       this.$refs.iptEmail.focus()
-
     })
   },
   methods: {
@@ -184,11 +182,11 @@ export default {
             tooShort: this.$t('auth:nameTooShort'),
             tooLong: this.$t('auth:nameTooLong')
           }
-        },
+        }
       }, { fullMessages: false })
 
       if (validation) {
-        if(validation.email) {
+        if (validation.email) {
           this.$store.commit('showNotification', {
             style: 'red',
             message: validation.email[0],

client/scss/base/reset.scss

@@ -1,7 +1,7 @@
 .dialog-header {
   background-color: mc('blue', '700');
-  background: radial-gradient(ellipse at top, mc('blue', '500'), mc('blue', '700')),
-            radial-gradient(ellipse at bottom, mc('blue', '800'), mc('blue', '700'));
+  background-image: radial-gradient(ellipse at top, mc('blue', '500'), mc('blue', '700')),
+                    radial-gradient(ellipse at bottom, mc('blue', '800'), mc('blue', '700'));
   height: 60px;
   color: #FFF;
   display: flex;
@@ -11,19 +11,19 @@
 
   &.is-red {
     background-color: mc('red', '700');
-    background: radial-gradient(ellipse at top, mc('red', '500'), mc('red', '700')),
-              radial-gradient(ellipse at bottom, mc('red', '800'), mc('red', '700'));
+    background-image: radial-gradient(ellipse at top, mc('red', '500'), mc('red', '700')),
+                      radial-gradient(ellipse at bottom, mc('red', '800'), mc('red', '700'));
   }
 
   &.is-indigo {
     background-color: mc('indigo', '700');
-    background: radial-gradient(ellipse at top, mc('indigo', '500'), mc('indigo', '700')),
-              radial-gradient(ellipse at bottom, mc('indigo', '800'), mc('indigo', '700'));
+    background-image: radial-gradient(ellipse at top, mc('indigo', '500'), mc('indigo', '700')),
+                      radial-gradient(ellipse at bottom, mc('indigo', '800'), mc('indigo', '700'));
   }
 
   &.is-dark {
     background-color: mc('grey', '900');
-    background: radial-gradient(ellipse at top, mc('grey', '800'), mc('grey', '900')),
-              radial-gradient(ellipse at bottom, mc('grey', '800'), mc('grey', '900'));
+    background-image: radial-gradient(ellipse at top, mc('grey', '800'), mc('grey', '900')),
+                      radial-gradient(ellipse at bottom, mc('grey', '800'), mc('grey', '900'));
   }
 }

client/scss/components/v-dialog.scss

@@ -79,15 +79,15 @@ module.exports = {
         stg.config.callbackURL = `${WIKI.config.host}/login/${stg.key}/callback`
         strategy.init(passport, stg.config)
 
-        fs.readFile(path.join(WIKI.ROOTPATH, `assets/svg/auth-icon-${strategy.key}.svg`), 'utf8').then(iconData => {
-          strategy.icon = iconData
-        }).catch(err => {
+        try {
+          strategy.icon = await fs.readFile(path.join(WIKI.ROOTPATH, `assets/svg/auth-icon-${strategy.key}.svg`), 'utf8')
+        } catch (err) {
           if (err.code === 'ENOENT') {
             strategy.icon = '[missing icon]'
           } else {
             WIKI.logger.warn(err)
           }
-        })
+        }
         WIKI.auth.strategies[stg.key] = strategy
         WIKI.logger.info(`Authentication Strategy ${stg.key}: [ OK ]`)
       }

server/core/auth.js

@@ -1,7 +1,5 @@
 /* global WIKI */
 
-const _ = require('lodash')
-const securityHelper = require('../helpers/security')
 const Model = require('objection').Model
 const moment = require('moment')
 const nanoid = require('nanoid')
@@ -68,7 +66,5 @@ module.exports = class UserKey extends Model {
     } else {
       throw new WIKI.Error.AuthValidationTokenInvalid()
     }
-
-    return token
   }
 }

server/models/userKeys.js

@@ -387,7 +387,7 @@ module.exports = () => {
     let key = conn.remoteAddress + ':' + conn.remotePort
     openConnections[key] = conn
     conn.on('close', () => {
-      delete openConnections[key]
+      openConnections.splice(key, 1)
     })
   })
 

server/setup.js

@@ -0,0 +1,5 @@
+sonar.projectKey=Requarks_wiki
+sonar.organization=requarks
+sonar.host.url=https://sonarcloud.io
+sonar.sources=./server,./client
+sonar.exclusions=./server/templates