Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Add action typing #131

Closed
krzema12 opened this issue Feb 1, 2023 · 4 comments
Closed

Add action typing #131

krzema12 opened this issue Feb 1, 2023 · 4 comments

Comments

@krzema12
Copy link

krzema12 commented Feb 1, 2023

Hi @m4heshd!

I'd like to ask you to add a piece of documentation. However, it won't be yet another piece of Markdown. When working with various actions, I discovered that it's challenging to know what type of data is needed for the inputs of an action, the same for outputs. Every action has its own custom way of documenting it, if it documents it at all, which makes it challenging for humans and automation to work with various actions. I figured there must be a way to address it.

I looked for an inspiration in other ecosystems where types were added later, like TypeScript adding types for JavaScript, or type hints in the Python world. I decided to create github-actions-typing which aspires to be the standardized way of typing your action's API. Onboarding is as easy as adding an extra action-types.yml file to your repository root, and (optionally, although highly recommended) adding a simple GitHub workflow that validates this new file. It has no negative effects on current action consumers, they continue to use the action as if the file wasn't there.

In this feature request, I would like to ask you if you're open to introducing such typings in your action. You wouldn't be first - there're already other actions using it, like e.g.: microsoft/setup-msbuild, Vampire/setup-wsl, ReactiveCircus/android-emulator-runner (full list of actions using the validation workflow is here)
If your answer is "yes", feel free to either add it yourself, or let me know - me or some of the other contributors would be happy to post a PR. We're also open to any kind of questions and feedback.

@m4heshd
Copy link
Contributor

m4heshd commented Feb 4, 2023

Hi, pinging @wei since they're the owner of this repo.

@heiskr
Copy link
Contributor

heiskr commented Feb 16, 2023

This is a wonderful idea. I don't think we would support this unless it became a built-in Actions feature, however.

@krzema12
Copy link
Author

@heiskr I don't think it will happen within the next year or two - GitHub is not really interested in implementing it. That's why I decided to create and maintain the library.

@heiskr
Copy link
Contributor

heiskr commented Jun 12, 2023

Thank you for opening this issue. Per the updated README, we are in process of archiving this repository, and encourage using gh pr create directly in your workflows instead.

@heiskr heiskr closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants