migrate from longhorn to openebs, then upgrade k8s past 1.24 (#4729)

* migrate from longhorn to openebs, then upgrade k8s past 1.24

* report this independently

* timing

* podstatus?

* all tests

Author: laverya

addons/openebs/3.7.0/install.sh

@@ -410,11 +410,21 @@ function openebs_prompt_migrate_from_longhorn() {
 
     semverParse "$KUBERNETES_VERSION"
     if [ "$minor" -gt 24 ] ; then
-        logFail "    It appears that the Kubernetes version you are attempting to install ($KUBERNETES_VERSION) is incompatible with the version of Longhorn currently installed"
-        logFail "    on your cluster. As a result, it is not possible to migrate data from Longhorn to OpenEBS. To successfully migrate data, please choose a Kubernetes"
-        logFail "    version that is compatible with the version of Longhorn running on your cluster (note: Longhorn is compatible with Kubernetes versions up to and"
-        logFail "    including 1.24)."
-        bail "Not migrating"
+        logWarn ""
+        logWarn "    It appears that the Kubernetes version you are attempting to install ($KUBERNETES_VERSION) is incompatible with the version of Longhorn currently installed"
+        logWarn "    on your cluster. Because of this, we will install OpenEBS and migrate your data from Longhorn before upgrading Kubernetes."
+
+        log "Would you like to continue? "
+        if ! confirmN; then
+            bail "Not migrating"
+        fi
+
+        longhorn_prepare_for_migration
+        report_addon_start "openebs-preinstall" "$OPENEBS_VERSION"
+        addon_install "openebs" "$OPENEBS_VERSION"
+        report_addon_success "openebs-preinstall" "$OPENEBS_VERSION"
+        maybe_cleanup_longhorn
+        return
     fi
 
     log "Would you like to continue? "

addons/openebs/template/base/install.sh

@@ -410,11 +410,21 @@ function openebs_prompt_migrate_from_longhorn() {
 
     semverParse "$KUBERNETES_VERSION"
     if [ "$minor" -gt 24 ] ; then
-        logFail "    It appears that the Kubernetes version you are attempting to install ($KUBERNETES_VERSION) is incompatible with the version of Longhorn currently installed"
-        logFail "    on your cluster. As a result, it is not possible to migrate data from Longhorn to OpenEBS. To successfully migrate data, please choose a Kubernetes"
-        logFail "    version that is compatible with the version of Longhorn running on your cluster (note: Longhorn is compatible with Kubernetes versions up to and"
-        logFail "    including 1.24)."
-        bail "Not migrating"
+        logWarn ""
+        logWarn "    It appears that the Kubernetes version you are attempting to install ($KUBERNETES_VERSION) is incompatible with the version of Longhorn currently installed"
+        logWarn "    on your cluster. Because of this, we will install OpenEBS and migrate your data from Longhorn before upgrading Kubernetes."
+
+        log "Would you like to continue? "
+        if ! confirmN; then
+            bail "Not migrating"
+        fi
+
+        longhorn_prepare_for_migration
+        report_addon_start "openebs-preinstall" "$OPENEBS_VERSION"
+        addon_install "openebs" "$OPENEBS_VERSION"
+        report_addon_success "openebs-preinstall" "$OPENEBS_VERSION"
+        maybe_cleanup_longhorn
+        return
     fi
 
     log "Would you like to continue? "

addons/openebs/template/testgrid/k8s-docker-localpv.yaml

@@ -178,7 +178,7 @@
     echo "Verify if rook-ceph namespace was removed after upgrade"
     if kubectl get namespace/rook-ceph ; then
        echo "Namespace rook-ceph was not removed"
-       exit 1 
+       exit 1
     else
        echo "Namespace rook-ceph was removed"
     fi
@@ -187,7 +187,7 @@
   flags: "yes"
   installerSpec:
     kubernetes:
-      version: "1.24.x" 
+      version: "1.24.x"
     flannel:
       version: latest
     containerd:
@@ -223,11 +223,11 @@
     source /opt/kurl-testgrid/testhelpers.sh
     minio_object_store_info
     validate_testfile rwtest testfile.txt
-    validate_read_write_object_store postupgrade upgradefile.txt    
+    validate_read_write_object_store postupgrade upgradefile.txt
     echo "Verify if rook-ceph namespace was removed after upgrade"
     if kubectl get namespace/rook-ceph ; then
        echo "Namespace rook-ceph was not removed"
-       exit 1 
+       exit 1
     else
        echo "Namespace rook-ceph was removed"
     fi
@@ -291,6 +291,12 @@
     # pulls the image we pushed before the migration.
     test_pull_image_from_registry
 
+    # ensure that longhorn has been removed
+    if kubectl get ns | grep -q longhorn-system; then
+      echo "longhorn-system namespace still exists"
+      exit 1
+    fi
+
 - name: localpv upgrade from latest
   flags: "yes"
   installerSpec:
@@ -333,3 +339,77 @@
     minio_object_store_info
     validate_testfile rwtest testfile.txt
     validate_read_write_object_store postupgrade upgradefile.txt
+
+
+- name: localpv migrate from longhorn with kubernetes upgrade
+  flags: "yes"
+  installerSpec:
+    kubernetes:
+      version: "1.24.9"
+    flannel:
+      version: "latest"
+    containerd:
+      version: "latest"
+    ekco:
+      version: "latest"
+    prometheus:
+      version: "0.60.1-41.7.3"
+    minio:
+      version: "latest"
+    registry:
+      version: "2.8.1"
+    longhorn:
+      version: "1.3.1"
+  upgradeSpec:
+    kubernetes:
+      version: "1.25.x"
+    flannel:
+      version: "latest"
+    containerd:
+      version: "latest"
+    ekco:
+      version: "latest"
+    prometheus:
+      version: "0.60.1-41.7.3"
+    minio:
+      version: "latest"
+    registry:
+      version: "2.8.1"
+    openebs:
+      isLocalPVEnabled: true
+      localPVStorageClassName: openebs
+      namespace: openebs
+      version: "__testver__"
+      s3Override: "__testdist__"
+  postInstallScript: |
+    source /opt/kurl-testgrid/testhelpers.sh
+    # create a deployment using the longhorn storage class ("default" namespace).
+    create_deployment_with_mounted_volume "migration-test" "default" "/data"
+    # generate a random file and copies it to the pod deployed by the previously created deployment.
+    create_random_file_and_upload_to_deployment "migration-test" "default" "./test.data" "/data/test.data"
+    # pushes an image to the internal registry.
+    test_push_image_to_registry
+    
+    sleep 60
+    kubectl get pods -A
+    kubectl get pod -n kurl -o jsonpath='{.status.reason}'
+  postUpgradeScript: |
+    source /opt/kurl-testgrid/testhelpers.sh
+    # sleep for a while to guarantee that the pod has been scaled up.
+    sleep 120
+    # downloads the previously stored file and compares, expecting to see the same content.
+    download_file_from_deployment_and_compare "migration-test" "default" "./test.data" "/data/test.data"
+    # makes sure that the new pvc is being provisioned by openebs.
+    pvc_uses_provisioner "migration-test" "default" "openebs"
+    # pulls the image we pushed before the migration.
+    test_pull_image_from_registry
+    
+    # ensure that kubernetes has upgraded
+    k8sVersion=$(kubectl get nodes -o jsonpath='{.items[0].status.nodeInfo.kubeletVersion}')
+    echo $k8sVersion | grep 1.25
+    
+    # ensure that longhorn has been removed
+    if kubectl get ns | grep -q longhorn-system; then
+      echo "longhorn-system namespace still exists"
+      exit 1
+    fi