Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated exception on PHP 7.1 #88

Closed
byrnedo opened this issue Nov 3, 2016 · 4 comments
Closed

Deprecated exception on PHP 7.1 #88

byrnedo opened this issue Nov 3, 2016 · 4 comments
Assignees

Comments

@byrnedo
Copy link
Contributor

byrnedo commented Nov 3, 2016

Function mcrypt_module_open() is deprecated in /usr/share/nginx/vendor/ircmaxell/random-lib/lib/RandomLib/AbstractMcryptMixer.php:75

I think that the fix might be to use random_bytes() in php 7+.

ircmaxell/RandomLib#55

Edit: locally using something like the following works to guard via version:

if(version_compare(phpversion(), '7.0', '>')){
...
@byrnedo
Copy link
Contributor Author

byrnedo commented Jan 12, 2017

See #89

@byrnedo
Copy link
Contributor Author

byrnedo commented Feb 15, 2017

@repejota Any plan to merge this soon? Are you still maintaining this project?

@repejota repejota self-assigned this Feb 15, 2017
@repejota
Copy link
Owner

Sure, I'll take a look ASAP sorry really busy lately. Gonna be be merged tomorrow maximum.

Thanks!

@byrnedo
Copy link
Contributor Author

byrnedo commented Feb 15, 2017

No worries, just wanted to check. It's nothing that can't wait a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants