Skip to content

Commit e1688f6

Browse files
Simone Manganellirentzsch
Simone Manganelli
authored andcommitted
change ClickToFlash's extension to .webplugin; update package to accomodate new extension and to clean up after older plugins; activate GC support in both Sparkle and ClickToFlash
Signed-off-by: Jonathan 'Wolf' Rentzsch <[email protected]>
1 parent e8dadfd commit e1688f6

File tree

6 files changed

+17
-11
lines changed

6 files changed

+17
-11
lines changed

ClickToFlash.xcodeproj/project.pbxproj

+8-6
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@
128128
072189BD0F30D9C3008C8944 /* English */ = {isa = PBXFileReference; lastKnownFileType = file.xib; name = English; path = Plugin/English.lproj/WhitelistPanel.xib; sourceTree = "<group>"; };
129129
55EB703C0E04A84F0016593D /* Plugin.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Plugin.h; path = Plugin/Plugin.h; sourceTree = "<group>"; };
130130
55EB703D0E04A84F0016593D /* Plugin.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = Plugin.m; path = Plugin/Plugin.m; sourceTree = "<group>"; };
131-
55EB70420E04A8640016593D /* ClickToFlash.plugin */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = ClickToFlash.plugin; sourceTree = BUILT_PRODUCTS_DIR; };
131+
55EB70420E04A8640016593D /* ClickToFlash.webplugin */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = ClickToFlash.webplugin; sourceTree = BUILT_PRODUCTS_DIR; };
132132
55EB70560E04A8B80016593D /* Cocoa.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Cocoa.framework; path = /System/Library/Frameworks/Cocoa.framework; sourceTree = "<absolute>"; };
133133
55EB70570E04A8B80016593D /* WebKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = WebKit.framework; path = /System/Library/Frameworks/WebKit.framework; sourceTree = "<absolute>"; };
134134
55EB70610E04A8D00016593D /* Info-Plugin.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; name = "Info-Plugin.plist"; path = "Plugin/Info-Plugin.plist"; sourceTree = "<group>"; };
@@ -194,7 +194,7 @@
194194
55EB70430E04A8640016593D /* Products */ = {
195195
isa = PBXGroup;
196196
children = (
197-
55EB70420E04A8640016593D /* ClickToFlash.plugin */,
197+
55EB70420E04A8640016593D /* ClickToFlash.webplugin */,
198198
B5CFF1740F40EEDB005DB9CC /* Whitelist Panel Harness.app */,
199199
);
200200
name = Products;
@@ -291,7 +291,7 @@
291291
);
292292
name = ClickToFlash;
293293
productName = ClickToFlash;
294-
productReference = 55EB70420E04A8640016593D /* ClickToFlash.plugin */;
294+
productReference = 55EB70420E04A8640016593D /* ClickToFlash.webplugin */;
295295
productType = "com.apple.product-type.bundle";
296296
};
297297
B5CFF1730F40EEDB005DB9CC /* Whitelist Panel Harness */ = {
@@ -406,7 +406,7 @@
406406
);
407407
runOnlyForDeploymentPostprocessing = 0;
408408
shellPath = /bin/sh;
409-
shellScript = "rm -Rf \"$HOME/Library/Internet Plug-Ins/ClickToFlash.plugin\"\ncp -R \"$BUILT_PRODUCTS_DIR/ClickToFlash.plugin\" \"$HOME/Library/Internet Plug-Ins/ClickToFlash.plugin\"\nexit 0";
409+
shellScript = "rm -Rf \"$HOME/Library/Internet Plug-Ins/ClickToFlash.plugin\"\nrm -Rf \"$HOME/Library/Internet Plug-Ins/ClickToFlash.webplugin\"\ncp -R \"$BUILT_PRODUCTS_DIR/ClickToFlash.plugin\" \"$HOME/Library/Internet Plug-Ins/ClickToFlash.plugin\"\nexit 0";
410410
};
411411
FADCD4210F421EAE00749805 /* ShellScript */ = {
412412
isa = PBXShellScriptBuildPhase;
@@ -542,6 +542,7 @@
542542
FRAMEWORK_SEARCH_PATHS = "$(BUILT_PRODUCTS_DIR)/$(FRAMEWORKS_FOLDER_PATH)";
543543
GCC_DYNAMIC_NO_PIC = NO;
544544
GCC_ENABLE_FIX_AND_CONTINUE = YES;
545+
GCC_ENABLE_OBJC_GC = YES;
545546
GCC_MODEL_TUNING = G5;
546547
GCC_OPTIMIZATION_LEVEL = 0;
547548
GCC_PRECOMPILE_PREFIX_HEADER = NO;
@@ -552,7 +553,7 @@
552553
PRODUCT_NAME = ClickToFlash;
553554
SDKROOT = /Developer/SDKs/MacOSX10.5.sdk;
554555
VALID_ARCHS = "i386 ppc ppc7400 ppc970 x86_64";
555-
WRAPPER_EXTENSION = plugin;
556+
WRAPPER_EXTENSION = webplugin;
556557
ZERO_LINK = NO;
557558
};
558559
name = Debug;
@@ -566,6 +567,7 @@
566567
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
567568
FRAMEWORK_SEARCH_PATHS = "$(BUILT_PRODUCTS_DIR)/$(FRAMEWORKS_FOLDER_PATH)";
568569
GCC_ENABLE_FIX_AND_CONTINUE = NO;
570+
GCC_ENABLE_OBJC_GC = YES;
569571
GCC_MODEL_TUNING = G5;
570572
GCC_PRECOMPILE_PREFIX_HEADER = NO;
571573
GCC_PREFIX_HEADER = "";
@@ -575,7 +577,7 @@
575577
PRODUCT_NAME = ClickToFlash;
576578
SDKROOT = /Developer/SDKs/MacOSX10.5.sdk;
577579
VALID_ARCHS = "i386 ppc ppc7400 ppc970 x86_64";
578-
WRAPPER_EXTENSION = plugin;
580+
WRAPPER_EXTENSION = webplugin;
579581
ZERO_LINK = NO;
580582
};
581583
name = Release;

Package/Package Template.pmdoc/01clicktoflash-contents.xml

+1-1
Large diffs are not rendered by default.
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<pkgref spec="1.12" uuid="3EB531D4-9A8B-4253-BCC3-2C37FD799BE1"><config><identifier>com.github.rentzsch.clicktoflash.pkg</identifier><version>1</version><description></description><post-install type="none"/><installFrom relative="true" mod="true" includeRoot="true">../build/Release/ClickToFlash.plugin</installFrom><installTo mod="true">/tmp</installTo><flags><followSymbolicLinks/><overwriteDirectoryPermissions/><allowRevert/><mod>overwriteDirectoryPermissions</mod><mod>allowRevert</mod></flags><packageStore type="internal"></packageStore><mod>installTo</mod><mod>scripts.scriptsDirectoryPath.isRelativeType</mod><mod>installTo.isAbsoluteType</mod><mod>installTo.isRelativeType</mod><mod>installFrom.isAbsoluteType</mod><mod>extraFiles</mod><mod>version</mod><mod>includeRoot</mod><mod>identifier</mod><mod>parent</mod><mod>scripts.postinstall.path</mod><mod>requireAuthorization</mod><mod>postInstall</mod><mod>scripts.preinstall.path</mod><mod>relocatable</mod><mod>installFrom.isRelativeType</mod><mod>installTo.path</mod><mod>scripts.preinstall.isRelativeType</mod><mod>scripts.scriptsDirectoryPath.path</mod><mod>installFrom.path</mod></config><scripts><preinstall relative="true" mod="true">preflight.txt</preinstall><postinstall relative="true" mod="true">postflight.txt</postinstall></scripts><contents><file-list>01clicktoflash-contents.xml</file-list><component id="com.github.rentzsch.clicktoflash" path="/Users/simmy/clicktoflash+simX/build/Release/ClickToFlash.plugin" version="1.4fc6"><component id="org.andymatuschak.Sparkle" path="/Users/simmy/clicktoflash+simX/build/Release/ClickToFlash.plugin/Contents/Frameworks/Sparkle.framework" version="1.5"/></component><filter>/CVS$</filter><filter>/\.svn$</filter><filter>/\.cvsignore$</filter><filter>/\.cvspass$</filter><filter>/\.DS_Store$</filter></contents><extra-files/></pkgref>
1+
<pkgref spec="1.12" uuid="3EB531D4-9A8B-4253-BCC3-2C37FD799BE1"><config><identifier>com.github.rentzsch.clicktoflash.pkg</identifier><version>1</version><description></description><post-install type="none"/><installFrom relative="true" mod="true" includeRoot="true">../build/Release/ClickToFlash.webplugin</installFrom><installTo mod="true">/tmp</installTo><flags><followSymbolicLinks/><overwriteDirectoryPermissions/><allowRevert/><mod>overwriteDirectoryPermissions</mod><mod>allowRevert</mod></flags><packageStore type="internal"></packageStore><mod>installFrom.path</mod><mod>scripts.scriptsDirectoryPath.isRelativeType</mod><mod>installTo.isAbsoluteType</mod><mod>installTo.isRelativeType</mod><mod>installFrom.isAbsoluteType</mod><mod>extraFiles</mod><mod>version</mod><mod>includeRoot</mod><mod>identifier</mod><mod>parent</mod><mod>scripts.postinstall.path</mod><mod>requireAuthorization</mod><mod>postInstall</mod><mod>scripts.preinstall.path</mod><mod>relocatable</mod><mod>installFrom.isRelativeType</mod><mod>installTo.path</mod><mod>scripts.preinstall.isRelativeType</mod><mod>installTo</mod><mod>scripts.scriptsDirectoryPath.path</mod></config><scripts><preinstall relative="true" mod="true">preflight.txt</preinstall><postinstall relative="true" mod="true">postflight.txt</postinstall></scripts><contents><file-list>01clicktoflash-contents.xml</file-list><component id="com.github.rentzsch.clicktoflash" path="/Users/simmy/clicktoflash+simX/build/Release/ClickToFlash.webplugin" version="1.4fc6"><component id="org.andymatuschak.Sparkle" path="/Users/simmy/clicktoflash+simX/build/Release/ClickToFlash.webplugin/Contents/Frameworks/Sparkle.framework" version="1.5"/></component><filter>/CVS$</filter><filter>/\.svn$</filter><filter>/\.cvsignore$</filter><filter>/\.cvspass$</filter><filter>/\.DS_Store$</filter></contents><extra-files/></pkgref>
+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
<pkmkdoc spec="1.12"><properties><title>ClickToFlash</title><build>/Users/simmy/clicktoflash+simX/Package/Package Template.pkg</build><organization>com.github.rentzsch.clicktoflash</organization><userSees ui="easy"/><min-target os="3"/><domain/></properties><distribution><versions min-spec="1.000000"/><scripts></scripts></distribution><description>ClickToFlash PackageMaker template.
1+
<pkmkdoc spec="1.12"><properties><title>ClickToFlash</title><build>/Users/simmy/clicktoflash+simX/Package/Package Template.pkg</build><organization>com.github.rentzsch.clicktoflash</organization><userSees ui="easy"/><min-target os="3"/><domain anywhere="true"/></properties><distribution><versions min-spec="1.000000"/><scripts></scripts></distribution><description>ClickToFlash PackageMaker template.
22

33
Make sure that you have the latest version of XCode when making changes as PackageMaker is generally a bit buggy. Use at least version 3.0.3.
44

5-
This package is currently configured to always install in $HOME. I didn't find a good way to let the user choose a system wide installation yet as we would always have to require admin rights.</description><contents><choice title="Internet Plug-Ins" id="clicktoflash" starts_selected="true" starts_enabled="true" starts_hidden="false"><pkgref id="com.github.rentzsch.clicktoflash.pkg"/></choice></contents><resources bg-scale="none" bg-align="bottomright"><locale lang="en"><resource relative="true" mod="true" type="background">Background.png</resource><resource relative="true" mod="true" type="readme">Read Me Panel.rtf</resource><resource relative="true" mod="true" type="conclusion">Conclusion Panel.rtfd</resource></locale></resources><requirements><requirement id="sosv" operator="ge" value="'10.5.0'"><message-title>ClickToFlash requires MacOS X 10.5 Leopard</message-title><message>ClickToFlash cannot be used with the version of Mac OS X installed on your computer.</message></requirement><requirement id="moun" operator="eq" value="'/'"><message>This software can only be installed on the root volume.</message></requirement></requirements><flags/><extra-files/><item type="file">01clicktoflash.xml</item><mod>properties.userDomain</mod><mod>preinstallActions.actions</mod><mod>properties.systemDomain</mod><mod>properties.customizeOption</mod><mod>properties.anywhereDomain</mod><mod>extraFiles</mod><mod>properties.title</mod><mod>description</mod><mod>postinstallActions.actions</mod></pkmkdoc>
5+
This package is currently configured to always install in $HOME. I didn't find a good way to let the user choose a system wide installation yet as we would always have to require admin rights.</description><contents><choice title="Internet Plug-Ins" id="clicktoflash" starts_selected="true" starts_enabled="true" starts_hidden="false"><pkgref id="com.github.rentzsch.clicktoflash.pkg"/></choice></contents><resources bg-scale="none" bg-align="bottomright"><locale lang="en"><resource relative="true" mod="true" type="background">Background.png</resource><resource relative="true" mod="true" type="readme">Read Me Panel.rtf</resource><resource relative="true" mod="true" type="conclusion">Conclusion Panel.rtfd</resource></locale></resources><requirements><requirement id="sosv" operator="ge" value="'10.5.0'"><message-title>ClickToFlash requires MacOS X 10.5 Leopard</message-title><message>ClickToFlash cannot be used with the version of Mac OS X installed on your computer.</message></requirement><requirement id="moun" operator="eq" value="'/'"><message>This software can only be installed on the root volume.</message></requirement></requirements><flags/><extra-files/><item type="file">01clicktoflash.xml</item><mod>properties.userDomain</mod><mod>properties.anywhereDomain</mod><mod>properties.systemDomain</mod><mod>properties.customizeOption</mod><mod>preinstallActions.actions</mod><mod>extraFiles</mod><mod>properties.title</mod><mod>description</mod><mod>postinstallActions.actions</mod></pkmkdoc>

Package/postflight.txt

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
#!/bin/sh
22

33
rm -rf "$HOME/Library/Internet Plug-Ins/ClickToFlash.plugin"
4-
mv /tmp/ClickToFlash.plugin "$HOME/Library/Internet Plug-Ins/"
4+
rm -rf "$HOME/Library/Internet Plug-Ins/ClickToFlash.webplugin"
5+
mv /tmp/ClickToFlash.webplugin "$HOME/Library/Internet Plug-Ins/"
56
pkgutil --forget com.github.rentzsch.clicktoflash.pkg
67

78
exit 0

Sparkle/Sparkle.xcodeproj/project.pbxproj

+3
Original file line numberDiff line numberDiff line change
@@ -977,6 +977,7 @@
977977
baseConfigurationReference = FA1941CA0D94A70100DD942E /* ConfigFrameworkDebug.xcconfig */;
978978
buildSettings = {
979979
ARCHS = "$(NATIVE_ARCH)";
980+
GCC_ENABLE_OBJC_GC = supported;
980981
};
981982
name = Debug;
982983
};
@@ -985,6 +986,7 @@
985986
baseConfigurationReference = FA1941D50D94A70100DD942E /* ConfigFrameworkRelease.xcconfig */;
986987
buildSettings = {
987988
GCC_DEBUGGING_SYMBOLS = full;
989+
GCC_ENABLE_OBJC_GC = supported;
988990
};
989991
name = Release;
990992
};
@@ -1014,6 +1016,7 @@
10141016
isa = XCBuildConfiguration;
10151017
baseConfigurationReference = 61072EB20DF2640C008FE88B /* ConfigFrameworkReleaseGCSupport.xcconfig */;
10161018
buildSettings = {
1019+
GCC_ENABLE_OBJC_GC = supported;
10171020
INSTALL_PATH = "@loader_path/../Frameworks";
10181021
};
10191022
name = "Release (GC dual-mode; 10.5-only)";

0 commit comments

Comments
 (0)