Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: behind-base cache logic #17656

Closed
wants to merge 6 commits into from
Closed

fix: behind-base cache logic #17656

wants to merge 6 commits into from

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Sep 6, 2022 •
edited
Loading

Changes

  • cache and use baseBranchSha instead of parentSha in cache logic
  • updates tests and types
  • use defaultBranch as baseBranch in onboardingBranch

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh requested review from rarkins, viceice and Gabriel-Ladzaretti and removed request for viceice September 6, 2022 18:01
viceice
viceice reviewed Sep 7, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just se small things

lib/workers/repository/onboarding/branch/rebase.ts Outdated Show resolved Hide resolved
lib/workers/repository/onboarding/branch/rebase.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/branch/reuse.ts Outdated Show resolved Hide resolved
lib/workers/repository/cache.ts Outdated Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh marked this pull request as draft September 15, 2022 05:20
@RahulGautamSingh
Copy link
Collaborator Author

Closing this one as it will be solved as a part of #17663

@RahulGautamSingh RahulGautamSingh deleted the fix/behind-base branch September 16, 2022 18:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins Awaiting requested review from rarkins

@Gabriel-Ladzaretti Gabriel-Ladzaretti Awaiting requested review from Gabriel-Ladzaretti

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renovate is stuck in an infinite loop overwriting a ci bot's commits
2 participants
@RahulGautamSingh @viceice