Extracting nested nuget dependencies in csproj files

[ruudhe]

What would you like Renovate to be able to do?
References in .csproj files can be placed inside an element like Choose instead of the usual ItemGroup elements inside the Project element:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>netstandard2.0</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="3.1.0" />
  </ItemGroup>

  <Choose>
    <When Condition="some-condition-like-exists">
      <ItemGroup>
        <ProjectReference Include="My.Package.csproj" />
      </ItemGroup>
    </When>
    <Otherwise>
      <ItemGroup>
        <PackageReference Include="My.Package" Version="1.0.0" />
      </ItemGroup>
    </Otherwise>
  </Choose>
</Project>

Any package references inside the Choose / When / Otherwise elements are not found, it would be nice if the extractor could support extracting these nested package references.

Did you already have any implementation ideas?
It could be done traversing through the xml elements instead of only the ItemGroup child elements, for example here

[viceice]

I declare this as bug because I suggested to remove deep traversal to speed up extraction.

Maybe we only should have a blacklist of elements to ignore (eg PropertyGroup) and traverse all other.

[rarkins]

Does it really take that much time to traverse a parsed XML file?

[viceice]

Does it really take that much time to traverse a parsed XML file?

Not sure, but these file can sometimes be pretty big. We should at least ignore PropertyGroup, as the they can't be a parent of our deps.

[renovate-release]

🎉 This issue has been resolved in version 24.77.1 🎉

The release is available on:

• GitHub release
• 24.77.1

Your semantic-release bot 📦🚀