Automerge patch not working?

[rarkins]

Transferred from #473 (comment):

Another thing: "automerge": "minor" – shouldn't this automerge commits such as this one, instead of creating a PR?:

[rarkins]

I set up a test here: renovate-tests/automerge#10 using your renovate.json config and travis-ci

It behaved as following:

• branch was created on run 1
• PR was not created on run 1 as prCreation is set to "not-pending"
• PR was created on run 2 after travis testing passed
• PR was not automerged on run 2 as Travis added a new status check for the PR
• PR was automerged on run 3 after travis went green again

@denkristoffer I notice in your repo that auth0-js is now up to 8.9.3. Did you merge that manually, or did renovate automerge it?

In your screenshot it shows 13 hours elapsed since the PR creation and still no automerge, so it looks like something was wrong.

There's a reasonable chance that whatever was wrong was fixed in this commit this morning: 2ca2e7c

[denkristoffer]

I merged it manually. I'll keep an eye on whether the commit this morning changed anything from here on.

[rarkins]

Ok, please reopen this issue if you find it happening again

[denkristoffer]

It's happening again 🙂

This Pull Request updates dependency @​storybook/react](https://github.com/storybooks/storybook) from v3.2.5 to v3.2.6

I've left it unmerged.

Oh, is it possible that it's due to warnings? Since the workspace warning is always in the PR.

[rarkins]

I think it's a config problem. I'm seeing:

"branch":"renovate/@storybook/react-3.x","level":30,"msg":"Pull Request #154 does not need updating"
"branch":"renovate/@storybook/react-3.x","level":20,"msg":"Checking #154 for automerge"
"branch":"renovate/@storybook/react-3.x","level":20,"msg":"No automerge"

I also found these log messages:

"msg":"No renovate.json found"
"msg": "Detected 2 package files: packages/website/package.json,package.json"
"packageFile":"packages/website/package.json","msg":"No renovate config"
"packageFile":"package.json","msg":"Found package.json renovate config"
"packageFile":"packages/website/package.json","depType":"devDependencies","dependency":"@storybook/react"

It looks like you have 2 package.json files but the config is in only one of them. Therefore any config you specify will be applied only to packages in that package.json and not to the other one. In theory we might be able to add some "overrideRepoConfig: true" option in future that lets one package.json specify the behaviour for all package files, but that's not supported today. You will need to either copy/paste the config into the second package.json, or into a renovate.json file in the root of the repo.

[denkristoffer]

Oh indeed, the renovate config is only in my root package.json, I just assumed that it would apply to the whole repository when placed there. I'll add the config to the different packages and see if that fixes it 👍