Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bitbucket): support fetching changelogs with source directory #32691

Merged
merged 8 commits into from
Nov 24, 2024
Merged

feat(bitbucket): support fetching changelogs with source directory #32691

merged 8 commits into from
Nov 24, 2024
+14 −7

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Nov 23, 2024 •
edited
Loading

Changes

Add bitbucket changelog support for monorepos via sourceDirectory config

Demonstration: setchy/renovate-atlaskit-changelog#8

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy setchy added the platform:bitbucket Bitbucket Cloud platform label Nov 23, 2024
@setchy setchy marked this pull request as draft November 23, 2024 14:48
@setchy setchy marked this pull request as ready for review November 23, 2024 16:37
@setchy setchy added the core:changelogs Related to changelogs/release notes fetching label Nov 23, 2024
@setchy setchy changed the title feat(bitbucket): changelog with source directory feat(bitbucket): support fetching changelogs with source directory Nov 23, 2024
@setchy
use node:path instead
07c88f5 
Signed-off-by: Adam Setch <[email protected]>
@setchy setchy requested a review from viceice November 24, 2024 13:26
@setchy
use node:path instead
7c65383 
Signed-off-by: Adam Setch <[email protected]>
viceice
viceice reviewed Nov 24, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/workers/repository/update/pr/changelog/bitbucket/index.ts Outdated Show resolved Hide resolved
@setchy
remove path basename
965a3d0 
Signed-off-by: Adam Setch <[email protected]>
@setchy setchy requested a review from viceice November 24, 2024 13:57
@rarkins rarkins added this pull request to the merge queue Nov 24, 2024
Merged via the queue into renovatebot:main with commit 1234169 Nov 24, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
core:changelogs Related to changelogs/release notes fetching platform:bitbucket Bitbucket Cloud platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@setchy @renovate-release @viceice @rarkins