-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(github): Sanitize mentions in commit bodies #30842
fix(github): Sanitize mentions in commit bodies #30842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️
🎉 This issue has been resolved in version 38.44.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@zharinov @rarkins @viceice could it be that this now causes strange Chinese characters to appear in commit messages (displayed in Github and TortoiseGit)? I guess it's because the zero-width space is interpreted as "舃" in these locations. |
@ceisele-r plesse start a new discussion then link here. Can you reproduce it on GitHub.com or it needs specific local settings? |
Follow-up discussion: #30911 |
Changes
Although GitHub doesn't render Markdown in the commit bodies, the mentions are triggered anyway.
Users can configure Renovate in such a way changelogs are rendered in the commit body, which may cause undesired notifications for GitHub users mentioned in the changelogs.
This PR fixes the problem by adding zero-width space after every occurrence of
@
character.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: