Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(constants): export PLATFORM_HOST_TYPES constant as value #30642

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

Shegox
Copy link
Contributor

@Shegox Shegox commented Aug 7, 2024

Changes

This PR makes the list of supported platforms available as a value.
This allows us to use it as well as values in other places.

Because typescript doesn't allow to get the values from the type, we create the values in an array and then derive the type from it to avoid double maintaining it.

Context

Part of #30641

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins enabled auto-merge August 7, 2024 12:32
@rarkins rarkins added this pull request to the merge queue Aug 7, 2024
Merged via the queue into renovatebot:main with commit fec6251 Aug 7, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.21.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants