Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/gradle): Add support for GCV 2.23.0 #29874

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

jamestoyer
Copy link
Contributor

@jamestoyer jamestoyer commented Jun 26, 2024

Changes

Update the Gradle Consistent Versions regex to support v2.23.0

Context

Version 2.23.0 of GCV subtly changed the versions.lock header, which means the regex no longer identifies it correct. Sadly, this wasn't called out in the changelog, but the change was made in palantir/gradle-consistent-versions#1194.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2024

CLA assistant check
All committers have signed the CLA.

@jamestoyer jamestoyer changed the title Add support for GCV 2.30.0 fix(manager/gradle): Add support for GCV 2.30.0 Jun 26, 2024
@jamestoyer jamestoyer changed the title fix(manager/gradle): Add support for GCV 2.30.0 fix(manager/gradle): Add support for GCV 2.23.0 Jun 26, 2024
@rarkins rarkins enabled auto-merge June 26, 2024 16:24
@rarkins rarkins added this pull request to the merge queue Jun 26, 2024
Merged via the queue into renovatebot:main with commit 9026c2d Jun 26, 2024
37 checks passed
@jamestoyer jamestoyer deleted the patch-1 branch June 26, 2024 16:43
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.419.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@@ -9,7 +9,7 @@ import { isDependencyString, versionLikeSubstring } from '../utils';
export const VERSIONS_PROPS = 'versions.props';
export const VERSIONS_LOCK = 'versions.lock';
export const LOCKFIlE_HEADER_TEXT = regEx(
/^# Run \.\/gradlew (?:--write-locks|writeVersionsLock) to regenerate this file/,
/^# Run \.\/gradlew (?:--write-locks|writeVersionsLock|writeVersionsLocks) to regenerate this file/,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/^# Run \.\/gradlew (?:--write-locks|writeVersionsLock|writeVersionsLocks) to regenerate this file/,
/^# Run \.\/gradlew (?:--write-locks|writeVersionsLocks?) to regenerate this file/,

wouldn't this be simpler?

bryannaegele pushed a commit to bryannaegele/renovate that referenced this pull request Jul 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants