Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset): group pinojs packages together #28890

Merged
merged 3 commits into from
May 7, 2024

Conversation

wolfy1339
Copy link
Contributor

Changes

Adds an entry to the monorepo config preset for Pino

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented May 7, 2024

CLA assistant check
All committers have signed the CLA.

@wolfy1339 wolfy1339 changed the title feat: group pinojs packages together feat(preset): group pinojs packages together May 7, 2024
@rarkins rarkins enabled auto-merge May 7, 2024 06:34
@rarkins rarkins added this pull request to the merge queue May 7, 2024
Merged via the queue into renovatebot:main with commit 80484aa May 7, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.349.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@@ -544,6 +544,7 @@ const orgGroups = {
ngrx: 'https://github.com/ngrx/',
nrwl: 'https://github.com/nrwl/',
octokit: 'https://github.com/octokit/',
pino: 'https://github.com/pinojs/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a good idea, they have different versions, so those PRs are immortal.

@rarkins we should revert this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Octokit has different versions for it's packages, so by that logic it should also be reverted.

rarkins added a commit that referenced this pull request May 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants