feat(preset): group pinojs packages together #28890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wolfy1339
changed the title
rarkins
approved these changes
May 7, 2024
|
🎉 This PR is included in version 37.349.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
viceice
requested changes
May 7, 2024
| @@ -544,6 +544,7 @@ const orgGroups = { | |||
| ngrx: 'https://github.com/ngrx/', | |||
| nrwl: 'https://github.com/nrwl/', | |||
| octokit: 'https://github.com/octokit/', | |||
| pino: 'https://github.com/pinojs/', | |||
There was a problem hiding this comment.
not a good idea, they have different versions, so those PRs are immortal.
@rarkins we should revert this
There was a problem hiding this comment.
Octokit has different versions for it's packages, so by that logic it should also be reverted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds an entry to the monorepo config preset for Pino
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: