Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/bundler): Update conservatively if strict fails #26929

Merged

Conversation

benlangfeld
Copy link
Contributor

Fixes #25955

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2024

CLA assistant check
All committers have signed the CLA.

@benlangfeld benlangfeld force-pushed the 20240129-bundler-strict-update-failure branch from 2c6dfd1 to 78237a4 Compare January 29, 2024 21:27
@benlangfeld benlangfeld force-pushed the 20240129-bundler-strict-update-failure branch from 78237a4 to 7f78e60 Compare January 29, 2024 21:28
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, elegant solution! Verified in reproduction repo: https://github.com/renovate-reproductions/25928/pull/1/files

@Goltergaul
Copy link

Goltergaul commented Jan 30, 2024

@benlangfeld thank you for looking into this. The solution looks good, i can confirm that doing bundler lock --minor --conservative --update dry-validation solves the issue in the reproduction

@rarkins rarkins added this pull request to the merge queue Jan 30, 2024
Merged via the queue into renovatebot:main with commit 9608537 Jan 30, 2024
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.159.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@benlangfeld benlangfeld deleted the 20240129-bundler-strict-update-failure branch January 30, 2024 13:33
rvanbutselaar pushed a commit to rvanbutselaar/renovate that referenced this pull request Feb 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundler artifact updating: retry without strict mode if strict fails
5 participants