Merge gitlabci-include to gitlabci manager

[viceice]

What would you like Renovate to be able to do?

The gitlabci-include manager should be merged into gitlabci manager. Both work on same files beside the include manager also follows Gitlab inclcudes and processes them if they are local.

If you have any ideas on how this should be implemented, please tell us here.

• merge the manager code
• migrate gitlabci-include config to gitlabci config

Is this a feature you are interested in implementing yourself?

Maybe

[viceice]

Maybe we can do it in without breaking

[rarkins]

Any changes to depType needed to differentiate them afterward?

[viceice]

gitlabci-includes only uses repository

renovate/lib/modules/manager/gitlabci-include/extract.ts

Lines 20 to 34 in ba3b0c2

	function extractDepFromIncludeFile(
	includeObj: GitlabIncludeProject
	): PackageDependency {
	const dep: PackageDependency = {
	datasource: GitlabTagsDatasource.id,
	depName: includeObj.project,
	depType: 'repository',
	};
	if (!includeObj.ref) {
	dep.skipReason = 'unknown-version';
	return dep;
	}
	dep.currentValue = includeObj.ref;
	return dep;
	}

gitlabci also traverses local includes, so we do that twice for docker images in gitlabci and for repository includes at gitlabci-includes 🙈

[viceice]

ProgammingLanguage=docker will be applied then 😕

renovate/lib/modules/manager/gitlabci/index.ts

Line 5 in ba3b0c2

export const language: ProgrammingLanguage = 'docker';

[TimKnight-DWP]

@viceice ->
gitlabci-includes handles the following types:

include:
  - project: my-proj/pipelines/node-pipeline
    file: pipeline/node-pipeline.yml
    ref: 2.5.0

whereas gitlabci handles docker tags etc referenced in a gitlab-ci.yml e.g.

    image: renovate/renovate:37-slim@sha256:4bfa4c3ec7c3ddf695283a6b22c3019ac77503597e5ad836ab3b34288a8cc961

I've seen you comment on: #14177 about issues when pinning digests in gitlabci-includes manager.

Would this change ensure that includes don't try and pin, as there is no SHA to pin, but that image references could still be pinned automatically?

[viceice]

yes