Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observe and fix HTTP response schemas #21357

Closed
zharinov opened this issue Apr 5, 2023 · 2 comments · Fixed by #21395
Closed

Observe and fix HTTP response schemas #21357

zharinov opened this issue Apr 5, 2023 · 2 comments · Fixed by #21395
Assignees
@zharinov
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:refactor Refactoring or improving of existing code

Comments

@zharinov
Copy link
Collaborator

zharinov commented Apr 5, 2023

Describe the proposed change(s).

The message Response does not match schema will be logged at the INFO level once per run.
We aim for eliminating them all before enforcing responses to strictly match provided schemas (throwing ZodError otherwise).
@zharinov zharinov added type:refactor Refactoring or improving of existing code status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Apr 5, 2023
@zharinov zharinov mentioned this issue Apr 5, 2023
Merged
6 tasks
@zharinov zharinov self-assigned this Apr 5, 2023
@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-5-triage labels Apr 5, 2023
@viceice
Copy link
Member

viceice commented Apr 5, 2023

we should log a link to this issue to report any occurrence on self-hosted renovate.

This was referenced Apr 6, 2023
Merged
Merged
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 35.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zharinov zharinov

Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:refactor Refactoring or improving of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(http): Throw errors for schema mismatch zharinov/renovate
4 participants
@zharinov @viceice @HonkingGoose @renovate-release