Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(poetry): handle dependency groups #17964

Merged
merged 10 commits into from
Oct 6, 2022
Merged

feat(poetry): handle dependency groups #17964

merged 10 commits into from
Oct 6, 2022

Conversation

mkniewallner
Copy link
Contributor

Changes

Supports Poetry dependency groups, per https://python-poetry.org/docs/managing-dependencies/#dependency-groups.

Context

Closes #17501

Note: I'm not fluent in TypeScript, so tell me if there are better ways to do the things implemented in this PR.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@mkniewallner mkniewallner marked this pull request as ready for review September 25, 2022 17:43
rarkins
rarkins requested changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. One suggested change, plus some questions/suggestions

lib/modules/manager/poetry/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/poetry/types.ts Show resolved Hide resolved
lib/modules/manager/poetry/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/poetry/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/poetry/extract.ts Outdated Show resolved Hide resolved
rarkins
rarkins previously approved these changes Oct 2, 2022
View reviewed changes
@rarkins rarkins requested a review from viceice October 2, 2022 04:49
viceice
viceice reviewed Oct 2, 2022
View reviewed changes
lib/modules/manager/poetry/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/poetry/extract.ts Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from viceice October 3, 2022 04:52
viceice
viceice reviewed Oct 4, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/poetry/__fixtures__/pyproject.12.toml Outdated Show resolved Hide resolved
lib/modules/manager/poetry/extract.spec.ts Outdated Show resolved Hide resolved
@mkniewallner mkniewallner requested a review from viceice October 5, 2022 21:22
@rarkins rarkins enabled auto-merge (squash) October 6, 2022 04:56
@rarkins rarkins merged commit 4c1b3e5 into renovatebot:main Oct 6, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.219.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mkniewallner mkniewallner deleted the feat/17501-support-poetry-dependency-groups branch October 6, 2022 10:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Poetry 1.2 groups
4 participants
@mkniewallner @renovate-release @viceice @rarkins