Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We're not updating all Markdown files which reference renovate/renovate docker tags #31

Closed
HonkingGoose opened this issue Dec 1, 2021 · 8 comments · Fixed by renovatebot/renovate#30653
Labels
bug Something isn't working

Comments

@HonkingGoose
Copy link
Contributor

The latest "update references to renovate/renovate" PR 1 did not update the references to renovate/renovate docker tags in the docs/usage/examples/self-hosting.md 2 file.

Example of a reference that was missed: 2:

Docker

Renovate is available for Docker via an automated build renovate/renovate.
It builds latest based on the main branch and all semver tags are published too.
For example, all the following are valid tags:

docker run --rm renovate/renovate
docker run --rm renovate/renovate:25.69.4
docker run --rm renovate/renovate:25.69
docker run --rm renovate/renovate:25

Here is the Renovate configuration that applies to the created PR:

.github/default.json

Lines 46 to 58 in 1cfabab

{
"description": "Update references to Docker tags for renovate/renovate in Markdown files weekly",
"matchPackageNames": ["renovate/renovate"],
"matchPaths": [".md"],
"extends": ["schedule:weekly"],
"automerge": true,
"stabilityDays": 0,
"separateMajorMinor": false,
"commitMessageTopic": "references to {{{depName}}}",
"semanticCommitType": "docs",
"semanticCommitScope": null,
"additionalBranchPrefix": "docs-"
},

I'm not sure what we need to change to get this working?

Footnotes

  1. https://github.com/renovatebot/renovate/pull/12911

  2. https://github.com/renovatebot/renovate/blob/main/docs/usage/examples/self-hosting.md 2

@viceice
Copy link
Member

viceice commented Dec 1, 2021

It's this regex manager:
https://github.com/renovatebot/.github/blob/main/default.json#L100-L108

I think we have a bug, when multiple different versions are updated.

@viceice
Copy link
Member

viceice commented Dec 1, 2021

/cc @rarkins

@rarkins
Copy link
Contributor

rarkins commented Dec 1, 2021

Not sure we ever use the sha in docs? We could maybe simplify the regex

@viceice
Copy link
Member

viceice commented Dec 1, 2021

I don't think it's the regex. I think renovate fails to update with auto replace

@astellingwerf
Copy link

I didn't reconstruct a full timeline for the introduction of this issue, but I think I figured this out.

We're hoping to see a change on the file with the path docs/usage/examples/self-hosting.md. But that path means that it is subject to exclusion from renovation due to :ignoremodulesandtests. That preset is part of the config:base preset, which in turn is referenced on

"config:base",

@astellingwerf
Copy link

That sorta means that this issue is dependent on renovatebot/renovate#11159, because the preset is set on the global level, meaning that today there is no way for ignorePresets to undo that.

@viceice
Copy link
Member

viceice commented May 28, 2022

That sorta means that this issue is dependent on renovatebot/renovate#11159, because the preset is set on the global level, meaning that today there is no way for ignorePresets to undo that.

i don't think that issue blocks this. we don't use any global config option in our presets.

@astellingwerf
Copy link

i don't think that issue blocks this. we don't use any global config option in our presets.

I think you're right @viceice, there was some confusion on my end on how ignorePreset doesn't work under certain conditions. It seems that they can't be applied on the package rule level. So I guess that if you want to exclude it on one package rule, you'll need to ignore the preset on the repo level, and then extend it on all except one package rule?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants