Restricts response fields used byt assertResponsesAreEqual

Author: jamesseanwright

reno/testing.ts

@@ -1,6 +1,30 @@
 import { assertEquals } from "../deps.ts";
 import { AugmentedResponse } from "./router.ts";
 
+export function createResponseSubset(
+  {
+    status,
+    statusText,
+    cookies,
+    headers,
+    ok,
+    redirected,
+    type,
+  }: AugmentedResponse,
+  body: string,
+) {
+  return {
+    status,
+    statusText,
+    cookies,
+    headers,
+    ok,
+    redirected,
+    type,
+    body,
+  };
+}
+
 export function createAssertResponsesAreEqual(assertEqls: typeof assertEquals) {
   return async function (
     actual: AugmentedResponse,
@@ -10,15 +34,11 @@ export function createAssertResponsesAreEqual(assertEqls: typeof assertEquals) {
       [actual, expected].map((res) => res.text()),
     );
 
+    /* It seems that deeply comparing the requests always fails
+     * so we instead have to match a subset of their fields. */
     assertEqls(
-      {
-        ...actual,
-        body: actualText,
-      },
-      {
-        ...expected,
-        body: expectedText,
-      },
+      createResponseSubset(actual, actualText),
+      createResponseSubset(expected, expectedText),
     );
   };
 }

reno/testing_test.ts

@@ -1,6 +1,9 @@
 import { testdouble } from "../deps.ts";
 import type { assertEquals } from "../deps.ts";
-import { createAssertResponsesAreEqual } from "./testing.ts";
+import {
+  createAssertResponsesAreEqual,
+  createResponseSubset,
+} from "./testing.ts";
 
 function createAssertEquals() {
   return testdouble.func("assertEqls") as typeof assertEquals;
@@ -20,14 +23,8 @@ Deno.test({
 
     testdouble.verify(
       assertEqls(
-        {
-          ...a,
-          body: "Response body A",
-        },
-        {
-          ...b,
-          body: "Response body B",
-        },
+        createResponseSubset(a, "Response body A"),
+        createResponseSubset(b, "Response body B"),
       ),
     );
   },