Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in test_loads.py #41

Open
mfeurer opened this issue Aug 11, 2015 · 7 comments
Open

Possible bug in test_loads.py #41

mfeurer opened this issue Aug 11, 2015 · 7 comments

Comments

@mfeurer
Copy link
Collaborator

mfeurer commented Aug 11, 2015

Hi,
I think I stumbled upon a bug in test_loads.py in the method test_format_correct. This test should not pass in my opinion because the only line of data is the same line which contains @data.

This also raises the question if a line which denotes @data should be checked with a u_row.startswith(). I propose to use a u_row.startswith() followed by a check if there is something else in the same line.

@mfeurer
Copy link
Collaborator Author

mfeurer commented Sep 11, 2015

@renatopp can you please have a look at this?

@renatopp
Copy link
Owner

Hey, @mfeurer, despite the ARFF documentation, I always test all our ARFF examples within Weka. Thus, if Weka opens a given file, I think we should open too.

For instance, this example ARFF can be opened with Weka (3.7+) so I guess there is no problem with this format.

For reference, the example we are discussing here is:

@relation "software metric"
@attribute number_of_files numeric
@attribute "lines of code" numeric
@attribute 'defect density' numeric
@data 10,10,10

@mfeurer
Copy link
Collaborator Author

mfeurer commented Sep 28, 2015

I posted an issue over at the wekalist. Let's see what happens.

@renatopp
Copy link
Owner

renatopp commented Oct 9, 2015

Hey @mfeurer, any news on this issue?

@mfeurer
Copy link
Collaborator Author

mfeurer commented Oct 9, 2015

They confirmed it's a bug. I wrote again (2 hours ago) to ask whether they are going to change the behaviour. Let's see what happens.

@mfeurer
Copy link
Collaborator Author

mfeurer commented Oct 12, 2015

It'll be fixed in the next release.

@mfeurer
Copy link
Collaborator Author

mfeurer commented Mar 14, 2018

I just check this with the latest release and WEKA still parses this one :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants