Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update Docusaurus and remove Babel plugin #545

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

arthurdenner
Copy link
Contributor

@arthurdenner arthurdenner commented Aug 5, 2021

Fixes #529.

From what I tested, the Babel plugin is causing the exports is not defined error.

It may be related to facebook/docusaurus#4789, shipped in Docusaurus packages @2.0.0-beta.1.

I tested the change successfully with npm run build and npm run serve but please test it on your own.

PS: A lot of changes in package-lock.json, most of them changes of white space (tabs to spaces maybe?)

@JonnyBurger
Copy link
Member

Wow 🤩 thanks a lot, just tested it and works great! The new docusaurus layout for mobile is great 😊 Let's ship it 🚀

@JonnyBurger JonnyBurger enabled auto-merge August 6, 2021 07:20
@JonnyBurger JonnyBurger merged commit bc70076 into remotion-dev:main Aug 6, 2021
@arthurdenner arthurdenner deleted the docs/update-packages branch August 6, 2021 08:44
@arthurdenner arthurdenner restored the docs/update-packages branch August 6, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot update to Docusaurus 2.0.0 beta 3 with twoslash enabled
2 participants