Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP: Extract GetRenderProgressResponse into separate file #2982

Merged
merged 1 commit into from
Oct 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/lambda-php/src/GetRenderProgressResponse.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?php

class GetRenderProgressResponse
{
public int $chunks;
public bool $done;
public float $overallProgress;
public string $type;
public ?string $outputFile;
public int $lambdasInvoked;
public int $renderSize;
public int $currentTime;
public bool $fatalErrorEncountered;
public ?int $timeToFinish;
public ?string $outBucket;
public ?string $outKey;
public ?string $bucket;
}
1 change: 1 addition & 0 deletions packages/lambda-php/src/PHPClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
use Aws\Credentials\CredentialProvider;
use Aws\Lambda\LambdaClient;
use Exception;
use GetRenderProgressResponse;
use stdClass;

require_once __DIR__ . '/Version.php';
Expand Down
16 changes: 0 additions & 16 deletions packages/lambda-php/src/RenderParams.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,6 @@ class RenderMediaOnLambdaResponse
public string $renderId;
}

class GetRenderProgressResponse
{
public int $chunks;
public bool $done;
public float $overallProgress;
public string $type;
public ?string $outputFile;
public int $lambdasInvoked;
public int $renderSize;
public int $currentTime;
public bool $fatalErrorEncountered;
public ?int $timeToFinish;
public ?string $outBucket;
public ?string $outKey;
public ?string $bucket;
}

class RenderParams
{
Expand Down