Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP: Extract GetRenderProgressResponse into separate file #2982

Merged
merged 1 commit into from
Oct 6, 2023
Merged

PHP: Extract GetRenderProgressResponse into separate file #2982

merged 1 commit into from
Oct 6, 2023
+19 −16

Conversation

JonnyBurger
Copy link
Member

Might solve an issue with Laravel:

It could have to do with that or it could be that Laravel and other php frameworks are more strict in this while plain php is fine.
I also recommend moving "GetRenderProgressResponse" out to its own file to not mess with frameworks namespaces
At least that solved the issues for me.

@vercel
Copy link

vercel bot commented Oct 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 8:02am
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 8:02am

@JonnyBurger JonnyBurger merged commit bd4dad5 into main Oct 6, 2023
10 checks passed
@JonnyBurger JonnyBurger deleted the php-get-render-progress-response-separate-file branch October 6, 2023 08:33
JonnyBurger added a commit that referenced this pull request Oct 23, 2023
@JonnyBurger
Merge pull request #2982 from remotion-dev/php-get-render-progress-re…
72b1f9a 
…sponse-separate-file

Former-commit-id: bd4dad5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JonnyBurger