Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chromiumOptions in PHP package #2981

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Fix chromiumOptions in PHP package #2981

merged 2 commits into from
Oct 6, 2023

Conversation

JonnyBurger
Copy link
Member

@JonnyBurger JonnyBurger commented Oct 6, 2023 •
edited
Loading

Also for the fix you mentiond. default to stdClass that was what cased the issue. Apparently it was not possible to default to std class since it is not possible to initialize a class property with a non-constant stdClass class, is not allowed as a default property value.

@vercel
Copy link

vercel bot commented Oct 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 7:15am
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 7:15am

@JonnyBurger JonnyBurger merged commit e624f0c into main Oct 6, 2023
10 checks passed
@JonnyBurger JonnyBurger deleted the fix-php-package branch October 6, 2023 07:52
JonnyBurger added a commit that referenced this pull request Oct 23, 2023
@JonnyBurger
Merge pull request #2981 from remotion-dev/fix-php-package
4b25180 
Former-commit-id: e624f0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JonnyBurger