Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookiecutter #3

Merged
merged 5 commits into from
May 30, 2023
Merged

Cookiecutter #3

merged 5 commits into from
May 30, 2023

Conversation

JvanderSaag
Copy link
Contributor

This PR introduces the following:

  • Repo is structured according to cookiecutter guidelines
  • Pylint and DSLinter is configured, and return perfect score
  • Repo still contains main.py for manual execution of the ML pipeline, this will be removed in later editions

@JvanderSaag JvanderSaag requested a review from a team as a code owner May 29, 2023 09:14
alemoraru
alemoraru requested changes May 30, 2023
View reviewed changes
Copy link
Contributor

@alemoraru alemoraru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to fix. Additionally, versioning should also be automatically incremented in a new commit when pushes to main are done. Let's have a chat about this "offline" - also to see how to automatically add linting and others on the pipeline.

docs/AUTHORS.rst Outdated Show resolved Hide resolved
docs/CONTRIBUTING.rst Outdated Show resolved Hide resolved
docs/LICENSE Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
src/__init__.py Outdated Show resolved Hide resolved
@JvanderSaag JvanderSaag requested a review from alemoraru May 30, 2023 11:33
@alemoraru alemoraru merged commit 346c4e4 into main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alemoraru alemoraru alemoraru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JvanderSaag @alemoraru