Avoid overly-specific assertion about charset-normalizer result #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harto
force-pushed
the
fix-encoding-detection-test
branch
from
783fe05
to
276c056
Compare
harto
changed the title
We don't pin charset-normalizer versions, so assertions about its behaviour are likely to flake. For example: - charset-normalizer 3.2.0 reports this encoding as cp037. - charset-normalizer 3.3.0 reports it as CP949. - charset-normalizer 3.3.1 and 3.3.2 report it as Big5. We don't care so much what the exact encoding is; we just care that we get a usable result. So, we change our assertion here to be much less specific.
harto
force-pushed
the
fix-encoding-detection-test
branch
from
da2370d
to
5b61461
Compare
Merged
dget
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't pin charset-normalizer versions, so this test is liable to flake as changes are made to that library.
cp037.CP949.Big5.So, we change the assertion here to be less specific (since we don't really care what specific encoding is returned — just that it's usable).