Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix Vite 2.6.0 False positives on Windows for server code leaking into client #8805

Closed
AlemTuzlak opened this issue Feb 20, 2024 · 2 comments

Comments

@AlemTuzlak
Copy link
Contributor

AlemTuzlak commented Feb 20, 2024

Reproduction

https://github.com/AlemTuzlak/remix-run-remix-btkct7

System Info

System:
    OS: Windows 11 10.0.22621
    CPU: (24) x64 12th Gen Intel(R) Core(TM) i9-12900K
    Memory: 6.93 GB / 31.71 GB
  Binaries:
    Node: 18.16.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.21 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 9.4.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.6.9 - ~\AppData\Roaming\npm\pnpm.CMD
  Browsers:
    Chrome: 121.0.6167.185
    Edge: Chromium (121.0.2277.128)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    @remix-run/dev: ^2.6.0 => 2.6.0
    @remix-run/eslint-config: ^2.3.1 => 2.3.1
    @remix-run/node: ^2.6.0 => 2.6.0
    @remix-run/react: ^2.6.0 => 2.6.0
    @remix-run/serve: ^2.6.0 => 2.6.0
    @remix-run/v1-route-convention: 0.1.4 => 0.1.4
    vite: ^5.1.3 => 5.1.3

Used Package Manager

npm

Expected Behavior

works without issues

Actual Behavior

false positives that warn me that the server code is leaking into the client when it's NOT

Additional info

If you run this on stackblitz it will work

Copy link
Contributor

🤖 Hello there,

We just published version 2.7.0-pre.4 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.7.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@pcattori pcattori added the vite label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants