Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect warning when using CSS Side-Effect Imports #6502

Closed
1 task done
Jackeriss opened this issue May 27, 2023 · 3 comments
Closed
1 task done

Incorrect warning when using CSS Side-Effect Imports #6502

Jackeriss opened this issue May 27, 2023 · 3 comments
Assignees
Labels
bug Something isn't working package:css-bundle

Comments

@Jackeriss
Copy link

Jackeriss commented May 27, 2023

What version of Remix are you using?

1.16.1

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

I'm using a ui library called semi-ui (https://github.com/DouyinFE/semi-design)
here is my remix.config.js:

/**
 * @type {import('@remix-run/dev').AppConfig}
 */
module.exports = {
  appDirectory: "app",
  assetsBuildDirectory: "public/build",
  publicPath: "/build/",
  serverBuildDirectory: "build",
  devServerPort: 8002,
  ignoredRouteFiles: [".*"],
  postcss: true,
  tailwind: true,
  future: {
    v2_routeConvention: true,
    unstable_dev: true,
  },
  serverDependenciesToBundle: [
    /^@douyinfe\/semi-ui/,
    /^@douyinfe\/semi-icons/,
    /^@douyinfe\/semi-illustrations/,
    /^@ant-design\/plots/,
    /^@antv/,
    /^lodash-es/,
  ],
};

Expected Behavior

Expect no warnings.

it was fine before version 1.15.0 with the config flag unstable_cssSideEffectImports

Actual Behavior

there are too many warnings at build time says i forgot to install the library, which is not true, cause the code works fine.

The path "@douyinfe/semi-foundation/lib/es/modal/modal.css?__remix_sideEffect__" is imported in  but "@douyinfe/semi-foundation/lib/es/modal/modal.css?__remix_sideEffect__" was not found in your node_modules. Did you forget to install it?
The path "@douyinfe/semi-foundation/lib/es/steps/steps.css?__remix_sideEffect__" is imported in  but "@douyinfe/semi-foundation/lib/es/steps/steps.css?__remix_sideEffect__" was not found in your node_modules. Did you forget to install it?
The path "@douyinfe/semi-foundation/lib/es/timeline/timeline.css?__remix_sideEffect__" is imported in  but "@douyinfe/semi-foundation/lib/es/timeline/timeline.css?__remix_sideEffect__" was not found in your node_modules. Did you forget to install it?
The path "@douyinfe/semi-foundation/lib/es/image/image.css?__remix_sideEffect__" is imported in  but "@douyinfe/semi-foundation/lib/es/image/image.css?__remix_sideEffect__" was not found in your node_modules. Did you forget to install it?

... etc

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-70cc627-20230602 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot closed this as completed Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

🤖 Hello there,

We just published version 1.17.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

🤖 Hello there,

We just published version 1.17.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package:css-bundle
Projects
None yet
Development

No branches or pull requests

3 participants