Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pick instead of Omit #8374

Merged
merged 11 commits into from
Dec 10, 2021
Merged

Use Pick instead of Omit #8374

merged 11 commits into from
Dec 10, 2021

Conversation

liuhanqu
Copy link
Contributor

Pick the property that would be use in navigator, so we can know which method can be use explicitly.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 22, 2021

Hi @liuhanqu,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@ghost
Copy link

ghost commented Nov 22, 2021

Hey there! 👋 This repository uses the Prettier code style.

You forgot to format these files in your pull request:

  • packages/react-router/index.tsx

The Prettier installation guide is a good place to get started with formatting your code properly.
Thanks!

❤️

Your friendly Prettifier bot.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 23, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@ryanflorence ryanflorence changed the base branch from main to dev December 9, 2021 23:51
@ryanflorence ryanflorence changed the base branch from dev to main December 9, 2021 23:52
@ryanflorence
Copy link
Member

ryanflorence commented Dec 9, 2021

Can you make this against the dev branch please, thanks :) (you'll want to rebase with dev, or just cherry-pick your commit onto it)

@ryanflorence ryanflorence added the accepted Accepted the changes, waiting for tests/CLA/etc. label Dec 9, 2021
@liuhanqu liuhanqu changed the base branch from main to dev December 10, 2021 01:06
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 10, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@liuhanqu
Copy link
Contributor Author

It's ok.

@timdorr
Copy link
Member

timdorr commented Dec 10, 2021

BTW, to review the actual code change here, just look at this commit: 47a5c32

@timdorr
Copy link
Member

timdorr commented Dec 10, 2021

I think Ryan was OK with this, so Imma merge this. Thanks @liuhanqu!

@timdorr timdorr merged commit 17f8e8e into remix-run:dev Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Accepted the changes, waiting for tests/CLA/etc. CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants