Skip to content

Conversation

@DimaAmega
Copy link
Contributor

@DimaAmega DimaAmega commented May 25, 2025

fix for issue #13672

I added a test (which failed before the fix) and fixed the bug as well

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2025

🦋 Changeset detected

Latest commit: d0e6555

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 25, 2025

Hi @DimaAmega,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 25, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title fix: scroll with revalidation fix(react-router): scroll with revalidation May 25, 2025
@DimaAmega
Copy link
Contributor Author

DimaAmega commented Jun 2, 2025

@timdorr @MichaelDeBoey Hi!

Just wanted to check if there's anything blocking the merge for this PR?

@DimaAmega
Copy link
Contributor Author

@timdorr @MichaelDeBoey friendly ping 🙂

@DimaAmega
Copy link
Contributor Author

ping @brophdawg11 @MichaelDeBoey @timdorr

I'm really looking forward to merge it 😊

@timdorr
Copy link
Member

timdorr commented Jun 13, 2025

@DimaAmega This will have to wait on a core team member to give a review. I know some of them have been on vacations, so it may be a bit longer until they can get to it.

@DimaAmega
Copy link
Contributor Author

Ok, got it! 😊

Thanks for the clarification

Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brophdawg11 brophdawg11 merged commit 633bbe7 into remix-run:dev Jun 30, 2025
5 checks passed
vezaynk pushed a commit to vezaynk/react-router that referenced this pull request Jul 7, 2025
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: revalidate causes page twitching effect while scrolling the page with <ScrollRestoration /> component

5 participants