Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Allow to override the location in the Routes in V6, like in the modal example in V5 #7949

Closed
fgatti675 opened this issue Aug 14, 2021 · 2 comments
Closed

[Feature]: Allow to override the location in the Routes in V6, like in the modal example in V5 #7949

fgatti675 opened this issue Aug 14, 2021 · 2 comments

Comments

@fgatti675
Copy link
Contributor

What is the new or updated feature that you are suggesting?

I have migrated my app to v6 but there is one feature I am missing.
In v5, you could specify the location, allowing you to build different cases depending on how you got there, like in the modal example.
https://reactrouter.com/web/example/modal-gallery
I haven't been able to find that feature in Routes or any equivalent way of achieving the same.
Sorry if I missed something!

Why should this feature be included?

It is useful for complicated navigation use cases
@fgatti675
Copy link
Contributor Author

I created a PR :)
#7969
Thanks for the awesome work!

@timdorr
Copy link
Member

timdorr commented Aug 22, 2021

See the discussion in #7946

@timdorr timdorr closed this as completed Aug 22, 2021
@fgatti675 fgatti675 mentioned this issue Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timdorr @fgatti675