Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: createMemoryRouter in test environment fails with node 18.15.0 #10273

Closed
neolivz opened this issue Mar 28, 2023 · 1 comment
Closed

[Bug]: createMemoryRouter in test environment fails with node 18.15.0 #10273

neolivz opened this issue Mar 28, 2023 · 1 comment
Labels

Comments

@neolivz
Copy link

neolivz commented Mar 28, 2023

What version of React Router are you using?

16.9.0

Steps to Reproduce

Code available at
https://github.com/neolivz/vitejs-vite-p4q1rh

Run pnpm test in node 18.15.0 (test works with node 18.14.0 and 19.8.1)

Expected Behavior

Test should run successfullyThe test

Actual Behavior

I get the following error

TypeError: The "emitter" argument must be an instance of EventEmitter or EventTarget. Received an instance of AbortSignal

@neolivz neolivz added the bug label Mar 28, 2023
@timdorr
Copy link
Member

timdorr commented Mar 28, 2023

This is an upstream bug with Node's unidici library: nodejs/undici#1910 (comment) It needs to be fixed by them, as we are using the API correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants