Limit matchRoutes optimization to client side routers (#12882)

Author: brophdawg11

.changeset/loud-masks-battle.md

@@ -0,0 +1,5 @@
+---
+"react-router": patch
+---
+
+REMOVE: limit matchRoutes optimization to client side

packages/react-router/__tests__/dom/ssr/components-test.tsx

@@ -150,9 +150,9 @@ describe("<NavLink />", () => {
 
 describe("<ServerRouter>", () => {
   it("handles empty default export objects from the compiler", async () => {
-    let staticHandlerContext = await createStaticHandler([
-      { id: "root", path: "/", children: [{ id: "empty", index: true }] },
-    ]).query(new Request("http://localhost/"));
+    let staticHandlerContext = await createStaticHandler([{ path: "/" }]).query(
+      new Request("http://localhost/")
+    );
 
     invariant(
       !(staticHandlerContext instanceof Response),

packages/react-router/lib/hooks.tsx

@@ -448,7 +448,7 @@ export function useRoutesImpl(
     `useRoutes() may be used only in the context of a <Router> component.`
   );
 
-  let { navigator } = React.useContext(NavigationContext);
+  let { navigator, static: isStatic } = React.useContext(NavigationContext);
   let { matches: parentMatches } = React.useContext(RouteContext);
   let routeMatch = parentMatches[parentMatches.length - 1];
   let parentParams = routeMatch ? routeMatch.params : {};
@@ -535,7 +535,12 @@ export function useRoutesImpl(
     remainingPathname = "/" + segments.slice(parentSegments.length).join("/");
   }
 
+  // Use data router matches when available to avoid another match routes call.
+  // Skip this during SSR because the matches coming in from StaticHandlerContext
+  // might be UI agnostic and we want the matches from the createStaticRouter's
+  // routes
   let matches =
+    !isStatic &&
     dataRouterState &&
     dataRouterState.matches &&
     dataRouterState.matches.length > 0