Skip to content

Commit 8da4a37

Browse files
authored
Apply suggestions from code review
Clarify containing type in deprecation messages
1 parent 798c2a2 commit 8da4a37

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

packages/react-router/lib/dom/ssr/routeModules.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ export interface MetaMatch<
130130
> {
131131
id: RouteId;
132132
pathname: DataRouteMatch["pathname"];
133-
/** @deprecated Use `loaderData` instead */
133+
/** @deprecated Use `MetaMatch.loaderData` instead */
134134
data: Loader extends LoaderFunction | ClientLoaderFunction
135135
? SerializeFrom<Loader>
136136
: unknown;
@@ -164,7 +164,7 @@ export interface MetaArgs<
164164
LoaderFunction | ClientLoaderFunction | unknown
165165
> = Record<string, unknown>,
166166
> {
167-
/** @deprecated Use `loaderData` instead */
167+
/** @deprecated Use `MetaArgs.loaderData` instead */
168168
data:
169169
| (Loader extends LoaderFunction | ClientLoaderFunction
170170
? SerializeFrom<Loader>

packages/react-router/lib/router/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -817,7 +817,7 @@ export interface UIMatch<Data = unknown, Handle = unknown> {
817817
/**
818818
* The return value from the matched route's loader or clientLoader
819819
*
820-
* @deprecated Use `loaderData` instead
820+
* @deprecated Use `UIMatch.loaderData` instead
821821
*/
822822
data: Data;
823823
/** The return value from the matched route's loader or clientLoader */

packages/react-router/lib/types/route-module-annotations.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ type MetaMatch<T extends MatchInfo> = Pretty<{
3535
params: Record<string, string | undefined>;
3636
pathname: string;
3737
meta: MetaDescriptor[];
38-
/** @deprecated Use `loaderData` instead */
38+
/** @deprecated Use `MetaMatch.loaderData` instead */
3939
data: GetLoaderData<T["module"]>;
4040
loaderData: GetLoaderData<T["module"]>;
4141
handle?: unknown;
@@ -56,7 +56,7 @@ type CreateMetaArgs<T extends RouteInfo> = {
5656
/**
5757
* The return value for this route's server loader function
5858
*
59-
* @deprecated Use `loaderData` instead
59+
* @deprecated Use `Route.MetaArgs.loaderData` instead
6060
*/
6161
data: T["loaderData"] | undefined;
6262
/** The return value for this route's server loader function */
@@ -117,7 +117,7 @@ type Match<T extends MatchInfo> = Pretty<{
117117
id: T["id"];
118118
params: Record<string, string | undefined>;
119119
pathname: string;
120-
/** @deprecated Use `loaderData` instead */
120+
/** @deprecated Use `Match.loaderData` instead */
121121
data: GetLoaderData<T["module"]>;
122122
loaderData: GetLoaderData<T["module"]>;
123123
handle: unknown;

0 commit comments

Comments
 (0)