New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for github enterprise #43

Open

cordoval opened this issue Dec 28, 2015 · 3 comments

Labels

Contributor

cordoval commented Dec 28, 2015

i think this change should be easy, i am myself trying to find the spot
but just asking here too

UPDATE:
https://github.com/google/go-github/blob/master/github/github.go#L27
and on NewClient method
https://github.com/google/go-github/blob/master/github/github.go#L132
we need to change there
https://github.com/remind101/conveyor/blob/master/builder/github.go#L22
here is another place that needs to be changed

ejholmes added the enhancement label

Contributor Author

cordoval commented Dec 29, 2015

another set of places that need to be updated

https://github.com/remind101/conveyor/blob/master/builder/docker/bin/build#L60
and
https://github.com/remind101/conveyor/blob/master/builder/docker/bin/build#L73

Contributor Author

cordoval commented Jan 4, 2016

@ejholmes any comments/guidance before trying to attempt a PR here?

Contributor Author

cordoval commented Jan 5, 2016

trying to address in #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment