Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wont let me build a branch name with "@" in it #16

Open
dalyons opened this issue Oct 7, 2015 · 2 comments
Open

wont let me build a branch name with "@" in it #16

dalyons opened this issue Oct 7, 2015 · 2 comments

Comments

@dalyons
Copy link

dalyons commented Oct 7, 2015

& I wanna.

@ejholmes
Copy link
Contributor

Apparently this is a limitation of docker tags, which must match [a-z0-9]+(?:[._-][a-z0-9]+)*. We could disable the branch tag if it doesn't match this regex, but then we'll lose the caching advantage. Might be better to just error out with a better error message.

@ejholmes
Copy link
Contributor

Another option would be to just use a hash of the branch name for the cache tag (but still push the branch for convenience, if it matches that regex).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants