-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0 support, circuit network exporter #41
base: master
Are you sure you want to change the base?
Conversation
Thanks for the patch, but when attempting to run this using a factorio docker server, I get this error in the logs.
|
@kalebr dang, I ran the wrong build command from bash history, and didn't even test the final build 🤦♂️ added fixed version above |
I get the same error. Nothing i do allows me to connect. Edit: Removing the following two lines from control.lua solves the problem. |
@kalebr i think we also ran into something with "handlers are not identical" when starting our playthrough - I think the issue was that the savefile was created with the old version of the mod (or maybe no mod whatsoever). The solution was creating the map again, with the mod loaded (bad news, if your map is already in progress :( ). The registrations to @remijouannet I see you self-assigned this, the circuit network feature should be relatively simple to remove, if you don't like it and only want the 2.0 patch. What it does (or at least should do): export every network connected to a constant combinator, i.e. it makes constant combinator act as the "prometheus combinator" that I've seen in some other PR. Unfortunately, I'm a bit tight on time with my university schedule and other liabilities, so honestly I would like to avoid any further work on this (because it means starting factorio to test any changes, and y'all know what can happen when you open Factorio). You can do whatever with my code contributed here. Thanks a lot for all your work put into maintaining this. |
fixes #29
fixes #40
this will need some cleanup before merging:
However, if anyone wants to play with this dirty patch on 2.0/Space Age, here you go:
graftorio2-mvolfik_0.0.1.zipd6a3ac8graftorio2-mvolfik_0.0.1.zip fixed build, no code changes in the repo
Note that this is a "new" mod, not a version of graftorio(2). You will need to remove the original graftorio(2) mod.