From cac9739142675b1ddac849b330726539236558f7 Mon Sep 17 00:00:00 2001 From: Remco Haszing Date: Fri, 26 Apr 2024 16:07:06 +0200 Subject: [PATCH] Use the marker data provider revalidate method This saves the need to dispose and recreate it entirely. --- index.d.ts | 2 +- package-lock.json | 12 ++++++------ src/index.ts | 9 ++------- 3 files changed, 9 insertions(+), 14 deletions(-) diff --git a/index.d.ts b/index.d.ts index 37145e7..4dc3fd7 100644 --- a/index.d.ts +++ b/index.d.ts @@ -95,7 +95,7 @@ export interface MonacoYaml extends IDisposable { /** * Recondigure `monaco-yaml`. */ - update: (options: MonacoYamlOptions) => undefined + update: (options: MonacoYamlOptions) => Promise } /** diff --git a/package-lock.json b/package-lock.json index 846d73d..3b2df33 100644 --- a/package-lock.json +++ b/package-lock.json @@ -7032,14 +7032,14 @@ } }, "node_modules/monaco-marker-data-provider": { - "version": "1.1.1", - "resolved": "https://registry.npmjs.org/monaco-marker-data-provider/-/monaco-marker-data-provider-1.1.1.tgz", - "integrity": "sha512-PGB7TJSZE5tmHzkxv/OEwK2RGNC2A7dcq4JRJnnj31CUAsfmw0Gl+1QTrH0W0deKhcQmQM0YVPaqgQ+0wCt8Mg==", + "version": "1.2.2", + "resolved": "https://registry.npmjs.org/monaco-marker-data-provider/-/monaco-marker-data-provider-1.2.2.tgz", + "integrity": "sha512-vLsgwsIm4fcqQAi54SsfLYuvWuIOgPV3kmkvtXVh7SGCO2cWvkXhLm4PAHpDyaK3w8AwWAxM/sP/vKXvZJi7Pw==", + "dependencies": { + "monaco-types": "^0.1.0" + }, "funding": { "url": "https://github.com/sponsors/remcohaszing" - }, - "peerDependencies": { - "monaco-editor": ">=0.30.0" } }, "node_modules/monaco-types": { diff --git a/src/index.ts b/src/index.ts index bc2c1ac..75fa707 100644 --- a/src/index.ts +++ b/src/index.ts @@ -120,14 +120,9 @@ export function configureMonacoYaml(monaco: MonacoEditor, options: MonacoYamlOpt markerDataProvider.dispose() }, - update(newOptions) { + async update(newOptions) { worker.updateCreateData(Object.assign(createData, newOptions)) - markerDataProvider.dispose() - markerDataProvider = registerMarkerDataProvider( - monaco, - 'yaml', - createMarkerDataProvider(worker.getWorker) - ) + await markerDataProvider.revalidate() } } }