Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme incorrectly states that script tags are processed #142

Closed
nwalters512 opened this issue Mar 10, 2020 · 2 comments
Closed

Readme incorrectly states that script tags are processed #142

nwalters512 opened this issue Mar 10, 2020 · 2 comments

Comments

@nwalters512
Copy link

The readme claims that this library parses <script> tags:

Are <script> tags parsed?
Although <script> tags and their contents are rendered on the server-side, they're not evaluated on the client-side. See #98.

However, it looks like #109 removed that functionality. This is unfortunate, as there's still value in processing <script> tags in server-side environments like Next.js's _document.js component.

Either the Readme should be updated to reflect this, or (ideally) support for <script> tags should be added again to support more advanced use cases.

@remarkablemark
Copy link
Owner

It was added back in #116, please update to the latest version or 0.8.1

@nwalters512
Copy link
Author

Apologies, that PR didn't come up in my searches! Thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants