Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Diametric::Persistence to be primary module #17

Open
avescodes opened this issue Nov 12, 2012 · 2 comments
Open

Refactor Diametric::Persistence to be primary module #17

avescodes opened this issue Nov 12, 2012 · 2 comments

Comments

@avescodes
Copy link
Contributor

Refactor Diametric::Persistence such that it becomes the primary module to include and the connection determines different behavior.

A suggestion from @yokolet:

.connect should take an argument :rest or :peer, #peer? and #rest? methods should be on the connection object

@avescodes
Copy link
Contributor Author

Starting on this issue.

@ghost ghost assigned avescodes Nov 12, 2012
@yokolet
Copy link
Contributor

yokolet commented Nov 13, 2012

Originally, Sam suggested this.

Currently, we need to specify peer or rest connection explicitly and define a model individually. But, it is possible to recognize which one is used from url.

The suggestion is putting two persistence models into one. That means we need Diametric::Persistence module only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants