Populate optional comps.xml unit fields [RHELDST-25995] #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcmahon-rh
requested review from
rohanpm,
rajulkumar and
rbikar
as code owners
amcmahon-rh
force-pushed
the
comps-fixup
branch
from
5191ea2 to
390a0ba
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #226 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 46 46
Lines 3224 3257 +33
=========================================
+ Hits 3224 3257 +33 ☔ View full report in Codecov by Sentry. |
rohanpm
requested changes
Sep 30, 2024
When pushing comps.xml files, if a unit already exists in Pulp, fields that have been removed from the comps.xml did not get overwritten. This resulted in unexpected older data being published from Pulp. This change extends the comps.xml parsing by giving an option to fill in all fields in comp unit classes from pulp-rpm. When the data is uploaded into pulp this will overwrite old unwanted data.
amcmahon-rh
force-pushed
the
comps-fixup
branch
from
390a0ba to
5803674
Compare
rohanpm
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pushing comps.xml files, if a unit already exists in Pulp, fields that have been removed from the comps.xml did not get overwritten. This resulted in unexpected older data being published from Pulp.
This change extends the comps.xml parsing by giving an option to fill in all fields in comp unit classes from pulp-rpm. When the data is uploaded into pulp this will overwrite old unwanted data.