Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Chromium newest versions #896

Closed
stanislav215 opened this issue Aug 28, 2024 · 9 comments · Fixed by #902
Closed

Support Chromium newest versions #896

stanislav215 opened this issue Aug 28, 2024 · 9 comments · Fixed by #902
Labels

Comments

@stanislav215
Copy link

From Chromium 128.0.6613.18 version, getting error:

/app/node_modules/puppeteer-core/lib/cjs/puppeteer/node/BrowserRunner.js:194
reject(new Error([
^

Error: Failed to launch the browser process!

Related to package: "puppeteer-core": "^9.0.0" in storycap/packages/storycrawler

Please add support.

@K-kind
Copy link

K-kind commented Aug 29, 2024

I encountered a similar issue in my project after the Chrome version of GitHub Actions was updated yesterday. The following error caused Storycap to stop working:

TimeoutError: Navigation timeout of 60000 ms exceeded

As a temporary solution, it can be fixed using the previous version of Chrome.

- name: Install Chrome
        id: chrome
        uses: browser-actions/setup-chrome@facf10a55b9caf92e0cc749b4f82bf8220989148 # v1.7.2
        with:
          chrome-version: 127
- name: Take Screenshots
  env:
    CHROME_PATH: ${{ steps.chrome.outputs.chrome-path }}
  run: npm run ci:screenshot

package.json

"ci:screenshot": "storycap http://localhost:6007 --chromiumPath $CHROME_PATH --serverCmd 'http-server storybook-static --ci -p 6007'"

@debiru
Copy link

debiru commented Sep 2, 2024

Today, I encountered this problem in my projects.

My project is running Storybook v6.5 and v7.x, and we will updating to Storybook v8.x.

It appears that this problem occurs with the latest version of Chrome (128) in combination with Storybook v8.x.

Storybook Chrome 127 Chrome 128
v6.5 OK OK
v7.x OK OK
v8.x OK Occured this problem

I would like to get a solution.

@Quramy
Copy link
Member

Quramy commented Sep 3, 2024

Hi.

I'm investigating this issue. But I still can't find how to fix this.

I can reproduce the following error, which is the same message of #896 (comment):

TimeoutError: Navigation timeout of 60000 ms exceeded
  • This error occurs on GHA CI (ubuntu-latest runner, Chromium: linux-128.0.6613.86)
  • This error does not occur in my local macbook (Chromium: mac_arm-128.0.6613.86 installed via npm i puppeteer )
  • This error does not occur for webpack based Storybook. It only occurs for Storybook built by Vite.
    • Storycap's implementation is agnostic for "how to build Storybook". I don't know why the kind of module bundler affects this error 🤔
  • Upgradeing puppeteer-core package does not solve this issue.

See #901 for details.

@Quramy
Copy link
Member

Quramy commented Sep 3, 2024

@K-kind @debiru

I suppressed the navigation timeout error on Chromium 128 and shipped as pre-patch version, https://www.npmjs.com/package/storycap/v/5.0.1-alpha.0 .

Would you try this and check if your timeout error goes away?

@k35o
Copy link

k35o commented Sep 4, 2024

@Quramy
I had the same problem, but was able to solve it by using the 5.0.1-alpah.0 version.Thanks for shipping!

This error does not occur for webpack based Storybook. It only occurs for Storybook built by Vite

As written above, I'm using a webpack based Storybook and I get the same error.

@Quramy
Copy link
Member

Quramy commented Sep 4, 2024

@k35o

I had the same problem, but was able to solve it by using the 5.0.1-alpah.0 version.Thanks for shipping!

Thanks for your reply 😄 I'll merge #902 and ship [email protected] soon.

@Quramy
Copy link
Member

Quramy commented Sep 4, 2024

@stanislav215 (and others)

I've closed this issue, but I could not reproduce your " Error: Failed to launch the browser process! " rejection.
I fixed only the navigation timeout error problem(#896 (comment))

If you're encountering the Failed to launch the browser process! , please re-open this issue. 🙏

@AndrewStobie
Copy link

I am still getting the timeout error with storycap 5.0.1 chromium 128 storybook ^8 that is webpack based fwiw...

@AndrewStobie
Copy link

Hey now I am getting the Failed to launch the browser process! issue 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants