We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using customDomain and, endpoint (in sdkOptions) at the same time on s3 compatible storage e.g. minio, the report url built incorrectly. Protocol is already included in endpoint. https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#constructor_details
customDomain
endpoint (in sdkOptions)
reg-suit/packages/reg-publish-s3-plugin/src/s3-publisher-plugin.ts
Line 43 in 8e23456
Sorry if s3 compatible storage is not supported.
"reg-publish-s3-plugin": { "bucketName": "regviz", "customDomain": "http://127.0.0.1:9000", "sdkOptions": { "endpoint": "http://127.0.0.1:9000", "accessKeyId": "xxx", "sslEnabled": false, "secretAccessKey": "yyy", "s3ForcePathStyle": true, "signatureVersion": "v4" }
reg-suit run
[reg-suit] info Report URL: http://127.0.0.1:9000/xxxx/index.html
[reg-suit] info Report URL: https://http://127.0.0.1:9000/xxxx/index.html
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the bug
When using
customDomain
and,endpoint (in sdkOptions)
at the same time on s3 compatible storage e.g. minio, the report url built incorrectly.Protocol is already included in endpoint.
https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#constructor_details
reg-suit/packages/reg-publish-s3-plugin/src/s3-publisher-plugin.ts
Line 43 in 8e23456
Sorry if s3 compatible storage is not supported.
Reproduced step
reg-suit run
Expected behavior
Actual behavior
Screenshots
The text was updated successfully, but these errors were encountered: