From 3cb44431288dd143bed6ba67e9b13afc2cde1aa9 Mon Sep 17 00:00:00 2001 From: Khaleel Al-Adhami Date: Fri, 31 Jan 2025 16:43:05 -0800 Subject: [PATCH] add evaluate time to the progress counter (#4722) --- reflex/app.py | 33 ++++++++++++++++++++++----------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/reflex/app.py b/reflex/app.py index ce68088161..dd4f4f5cb2 100644 --- a/reflex/app.py +++ b/reflex/app.py @@ -958,20 +958,16 @@ def get_compilation_time() -> str: should_compile = self._should_compile() - for route in self._unevaluated_pages: - console.debug(f"Evaluating page: {route}") - self._compile_page(route, save_page=should_compile) + if not should_compile: + for route in self._unevaluated_pages: + console.debug(f"Evaluating page: {route}") + self._compile_page(route, save_page=should_compile) - # Add the optional endpoints (_upload) - self._add_optional_endpoints() + # Add the optional endpoints (_upload) + self._add_optional_endpoints() - if not should_compile: return - self._validate_var_dependencies() - self._setup_overlay_component() - self._setup_error_boundary() - # Create a progress bar. progress = Progress( *Progress.get_default_columns()[:-1], @@ -980,16 +976,31 @@ def get_compilation_time() -> str: ) # try to be somewhat accurate - but still not 100% - adhoc_steps_without_executor = 6 + adhoc_steps_without_executor = 7 fixed_pages_within_executor = 5 progress.start() task = progress.add_task( f"[{get_compilation_time()}] Compiling:", total=len(self._pages) + + (len(self._unevaluated_pages) * 2) + fixed_pages_within_executor + adhoc_steps_without_executor, ) + for route in self._unevaluated_pages: + console.debug(f"Evaluating page: {route}") + self._compile_page(route, save_page=should_compile) + progress.advance(task) + + # Add the optional endpoints (_upload) + self._add_optional_endpoints() + + self._validate_var_dependencies() + self._setup_overlay_component() + self._setup_error_boundary() + + progress.advance(task) + # Get the env mode. config = get_config()