Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spree 2.0 incompatibility due to truncate_html version #2275

Closed
rounders opened this issue May 23, 2013 · 6 comments
Closed

spree 2.0 incompatibility due to truncate_html version #2275

rounders opened this issue May 23, 2013 · 6 comments

Comments

@rounders
Copy link
Contributor

it appears that spree 2.0 has a dependency for truncate_html 0.9.2 while refinery has a dependency for truncate_html ~ 0.5.5

I understand from previous discussions regarding truncate_html that newer versions of the gem do not work with ruby 1.8.7. Is 1.8.7 compatibility the only reason for using this older version of truncate_html, or are there other reasons?

@ugisozols
Copy link
Member

IIRC then yes - it was compatibility issue with 1.8.7. See c401085.

@rounders
Copy link
Contributor Author

thanks @ugisozols

what do you think about relaxing the version requirement for truncate_html while adding a note to the documentation that ruby 1.8.7 users will need to specify 0.5.5 in their Gemfile? Or do you think there is there a better way to solve this?

@parndt
Copy link
Member

parndt commented May 24, 2013

We could stop supporting ruby 1.8.7 on the master branch, specify minimum ruby version and increase the truncate_html dependency version?

@rounders
Copy link
Contributor Author

@parndt deprecating 1.8.7 doesn't sound unreasonable to me given that it is approaching end of life and given that rails 4 won't support it.

@ugisozols
Copy link
Member

👍 for dropping 1.8.7 support since Rails 4 don't support it either.

@ugisozols
Copy link
Member

#2277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants