Skip to content

Commit e3234bf

Browse files
committed
Merge pull request #1940 from refinery/moving_on_from_ie6
Removed upgrade messages for IE.
2 parents 0a82ec5 + cb734ef commit e3234bf

File tree

7 files changed

+9
-94
lines changed

7 files changed

+9
-94
lines changed

Diff for: core/app/views/layouts/application.html.erb

+6-7
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,20 @@
11
<!DOCTYPE html>
2-
<%= render '/refinery/html_tag' %>
2+
<%= render "/refinery/html_tag" %>
33
<% site_bar = render('/refinery/site_bar', :head => true) -%>
4-
<%= render '/refinery/head' %>
5-
<body id='<%= canonical_id @page %>'>
4+
<%= render "/refinery/head" %>
5+
<body id="<%= canonical_id @page %>">
66
<%= site_bar -%>
7-
<%= render '/refinery/ie6check' if request.env['HTTP_USER_AGENT'] =~ /MSIE/ -%>
87
<div id="page_container">
98
<header id="header">
10-
<%= render '/refinery/header' -%>
9+
<%= render "/refinery/header" -%>
1110
</header>
1211
<section id="page">
1312
<%= yield %>
1413
</section>
1514
<footer>
16-
<%= render '/refinery/footer' -%>
15+
<%= render "/refinery/footer" -%>
1716
</footer>
1817
</div>
19-
<%= render '/refinery/javascripts' %>
18+
<%= render "/refinery/javascripts" %>
2019
</body>
2120
</html>

Diff for: core/app/views/refinery/_ie6check.html.erb

-63
This file was deleted.

Diff for: core/lib/generators/refinery/core/templates/config/initializers/refinery/core.rb.erb

-6
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,6 @@ Refinery::Core.configure do |config|
3838
# Log info (in console) about rack cache state for resources when you run webserver
3939
# config.verbose_rack_cache = <%= Refinery::Core.verbose_rack_cache.inspect %>
4040

41-
# Show/hide IE6 upgrade message in the backend
42-
# config.ie6_upgrade_message_enabled = <%= Refinery::Core.ie6_upgrade_message_enabled.inspect %>
43-
44-
# Show/hide browser update message in the backend
45-
# config.show_internet_explorer_upgrade_message = <%= Refinery::Core.show_internet_explorer_upgrade_message.inspect %>
46-
4741
# Add extra tags to the wymeditor whitelist e.g. = {'tag' => {'attributes' => {'1' => 'href'}}} or just {'tag' => {}}
4842
# config.wymeditor_whitelist_tags = <%= Refinery::Core.wymeditor_whitelist_tags.inspect %>
4943

Diff for: core/lib/refinery/core/configuration.rb

+3-5
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ module Core
44

55
config_accessor :rescue_not_found, :s3_backend, :base_cache_key, :site_name,
66
:google_analytics_page_code, :authenticity_token_on_frontend,
7-
:menu_hide_children, :menu_css, :dragonfly_secret, :ie6_upgrade_message_enabled,
8-
:show_internet_explorer_upgrade_message, :wymeditor_whitelist_tags,
9-
:javascripts, :stylesheets, :s3_bucket_name, :s3_region, :s3_access_key_id,
7+
:menu_hide_children, :menu_css, :dragonfly_secret,
8+
:wymeditor_whitelist_tags, :javascripts, :stylesheets,
9+
:s3_bucket_name, :s3_region, :s3_access_key_id,
1010
:s3_secret_access_key, :force_ssl, :verbose_rack_cache
1111

1212
self.rescue_not_found = false
@@ -18,8 +18,6 @@ module Core
1818
self.menu_hide_children = false
1919
self.menu_css = { :selected => "selected", :first => "first", :last => "last" }
2020
self.dragonfly_secret = Array.new(24) { rand(256) }.pack('C*').unpack('H*').first
21-
self.ie6_upgrade_message_enabled = true
22-
self.show_internet_explorer_upgrade_message = false
2321
self.wymeditor_whitelist_tags = {}
2422
self.javascripts = []
2523
self.stylesheets = []

Diff for: dashboard/app/controllers/refinery/admin/dashboard_controller.rb

-5
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,6 @@ def index
2929
end
3030
end
3131

32-
def disable_upgrade_message
33-
Refinery::Core.show_internet_explorer_upgrade_message = false
34-
render :nothing => true
35-
end
36-
3732
end
3833
end
3934
end

Diff for: dashboard/app/views/refinery/admin/dashboard/index.html.erb

-4
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,3 @@
77
<%= render 'actions' %>
88
</aside>
99
</div>
10-
<% if request.env["HTTP_USER_AGENT"] =~ /MSIE/ and
11-
Refinery::Core.show_internet_explorer_upgrade_message %>
12-
<% flash.now[:message] = render(:partial => "/refinery/ie6check") %>
13-
<% end %>

Diff for: dashboard/config/routes.rb

-4
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
Refinery::Core::Engine.routes.draw do
22
namespace :admin, :path => 'refinery' do
33
get 'dashboard', :to => 'dashboard#index', :as => :dashboard
4-
5-
get 'disable_upgrade_message',
6-
:to => 'dashboard#disable_upgrade_message',
7-
:as => :disable_upgrade_message
84
end
95
end

0 commit comments

Comments
 (0)