Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid grid showing incorrect values #3745

Open
jordantuck20 opened this issue Jan 6, 2025 · 4 comments
Open

Fluid grid showing incorrect values #3745

jordantuck20 opened this issue Jan 6, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@jordantuck20
Copy link

Describe the bug

Playing ATM9 via CurseForge.

In the fluid grid, the value shown for Liquid Deuterium is incorrect. It will cycle quickly between 0 and 20 buckets as it is imported into the system, but I have at least 1.7M buckets. When removing a 1048m fluid storage disk (from Extra Disks 1.20.1-3.0.2), the number jumps to 1.8M. Then when putting the disk back into the system, it return to cycling between 0 and 20. When setting a storage monitor to that liquid, it shows 2.1M.

Uploading fluid-value-bug.mp4…

The numbers were all displaying correctly for weeks until 2025-01-06.

How can we reproduce this bug or crash?

Unable to reproduce outside this world.
Tested importing max amounts of 6 different liquids to a system using the same version of Extra Disks, but no issues arose. However, testing occurred in a single player world with none of the same machines importing the liquids and fewer unique liquids in the system.

What Minecraft version is this happening on?

Minecraft 1.20.1

What Forge version is this happening on?

47.3.11

What Refined Storage version is this happening on?

1.12.4

Relevant log output

No response

@jordantuck20 jordantuck20 added the bug Something isn't working label Jan 6, 2025
@jordantuck20
Copy link
Author

@Nodrance
Copy link
Collaborator

Nodrance commented Jan 6, 2025

2.1M buckets. So around 2.14 billion millibuckets. You hit the integer limit methinks

@jordantuck20
Copy link
Author

That makes sense, but odd it's not showing the value as the max. In my testing world, I could see when it hit max and stopped importing the liquid. In the video, you can see it is still acting like it's importing - but I'm not currently exporting any of that liquid, so it should hit the max and stop, correct?

@jordantuck20
Copy link
Author

jordantuck20 commented Jan 8, 2025

I did some more testing today. I do have the max integer limit stored and am importing more of that liquid. It does not show the 2.1M buckets, but as soon as you open the fluid grid, it starts increasing from 0 based on whatever is being imported until you exit the fluid grid, then starts over when you open it again.

So it appears to not stop you from importing additional liquid above the max integer and cannot properly display the value if you keep importing beyond that. However, once you stop importing that liquid, it displays as the max integer, so it is only while actively importing more of that liquid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants