fix: dupe bug with controller

Remainders weren't being accounted for when inserting to player inv.

Fixes #3544

Author: raoulvdberge

src/main/java/com/refinedmods/refinedstorage/apiimpl/network/grid/CraftingGridBehavior.java

@@ -23,6 +23,9 @@
 import net.minecraftforge.common.ForgeHooks;
 import net.minecraftforge.event.ForgeEventFactory;
 import net.minecraftforge.items.ItemHandlerHelper;
+import net.minecraftforge.items.wrapper.InvWrapper;
+import net.minecraftforge.items.wrapper.PlayerInvWrapper;
+import net.minecraftforge.items.wrapper.PlayerMainInvWrapper;
 
 import javax.annotation.Nullable;
 import java.util.*;
@@ -123,16 +126,18 @@ public void onCraftedShift(INetworkAwareGrid grid, Player player) {
         }
 
         for (ItemStack craftedItem : craftedItemsList) {
-            if (!player.getInventory().add(craftedItem.copy())) {
-                ItemStack remainder = craftedItem;
-
-                if (useNetwork) {
-                    remainder = network.insertItem(craftedItem, craftedItem.getCount(), Action.PERFORM);
-                }
+            ItemStack remainder = ItemHandlerHelper.insertItem(
+                    new PlayerMainInvWrapper(player.getInventory()),
+                    craftedItem.copy(),
+                    false
+            );
+
+            if (!remainder.isEmpty() && useNetwork) {
+                remainder = network.insertItem(remainder, remainder.getCount(), Action.PERFORM);
+            }
 
-                if (!remainder.isEmpty()) {
-                    Containers.dropItemStack(player.getCommandSenderWorld(), player.getX(), player.getY(), player.getZ(), remainder);
-                }
+            if (!remainder.isEmpty()) {
+                Containers.dropItemStack(player.getCommandSenderWorld(), player.getX(), player.getY(), player.getZ(), remainder);
             }
         }