[yarn rwfw]: clean before building, don't exit on errors #3074
Conversation
|
@jtoar - what I was suggesting re: capturing the errors is the following: On error, capture the error, and display an error message to the user (could not build & sync ${package}) . This means that if you have some sort of error in the code you're modifying (which is possible, and common when you're devving, especially with types) - the watcher continues to run, and I don't have to rerun This would be in addition to clean before build change you've just done. |
|
|
Per conversation, #3082 will make "clean before building" unnecessary (since the original need was addressing a bug with ttsc package). Regardless, we would still use this PR for improved error catch/output. If we do need to proceed with the "clean before building" approach, then it will be important for performance to only re-build changed packages. |
jtoar
changed the title
| try { | ||
| buildPackages([packageJsonPath], { clean: true }) | ||
|
|
||
| console.log() | ||
| logStatus(`Copying ${packageName}...`) | ||
| copyFrameworkFilesToProject(projectPath, [packageJsonPath]) | ||
| console.log() | ||
| logStatus(`Copying ${packageName}...`) | ||
| copyFrameworkFilesToProject(projectPath, [packageJsonPath]) |
There was a problem hiding this comment.
If there's an error building a package, it doesn't make sense to proceed in copying it over so I included it in the try-catch block
| if (clean) { | ||
| for (const packageJsonPath of packages) { | ||
| rimraf.sync(path.join(path.dirname(packageJsonPath), 'dist')) | ||
| } | ||
| } |
There was a problem hiding this comment.
rimraf.sync doesn't take arrays of filepaths until v4 so we'll have to loop it for now
|
Discussion reminder: add |
|
@thedavidprice done thanks to @alicelovescake! 🚀 |
Currently, if you edit a typescript file while
yarn rwfw project:syncis running, you'll most likely run into issue #3053. The reason for this is that there's a bug in ttsc: it's incompatible with the version of typescript we're using (see this comment here: #3053 (comment)).ttsc hasn't been updated in a while so it seems unlikely that this issue will be fixed. As @Tobbe said in the comment linked above, migrating to ts-patch v2 seems like the long-term solution. The issue there though is ts-patch v2 is in beta. But we could certainly help out the project by becoming an early tester.
Since there's some uncertainty about ts-patch / work would have to be done to see if it's viable, this PR provides a temporary fix to make contributing easier in the meantime. All this PR does is add a cleaning step before building.
This PR also ignores a new filepath,
dist(without the trailing slash). Since we're listening to all chokidar events, one of which isaddDir, now that we runbuild:clean, theaddDirevent fires on build (a new directory dist was added), causing it clean and build, over and over again. Ignoringdistfixes that.Another option that was discussed was catching the error and consoling a helpful message. I'm less inclined to go that route since the goal of a contributing tool is to ease friction and let the contributor just contribute. Having to run
build:cleanyourself after every change sounds a little too tedious.