chore(react): use updater callback function (#6424)

Author: virtuoushub

packages/auth/src/AuthProvider.tsx

@@ -264,12 +264,14 @@ export class AuthProvider extends React.Component<
           ? null
           : await this.getCurrentUser()
 
-        this.setState({
-          ...this.state,
-          userMetadata,
-          currentUser,
-          isAuthenticated: true,
-          loading: false,
+        this.setState((prevState) => {
+          return {
+            ...prevState,
+            userMetadata,
+            currentUser,
+            isAuthenticated: true,
+            loading: false,
+          }
         })
       }
     } catch (e: any) {

packages/router/src/__tests__/router.test.tsx

@@ -87,12 +87,18 @@ const mockUseAuth =
       useState(isAuthenticated)
 
     useEffect(() => {
+      let timer: NodeJS.Timeout | undefined
       if (loadingTimeMs) {
-        setTimeout(() => {
+        timer = setTimeout(() => {
           setAuthLoading(false)
           setAuthIsAuthenticated(true)
         }, loadingTimeMs)
       }
+      return () => {
+        if (timer) {
+          clearTimeout(timer)
+        }
+      }
     }, [])
 
     return createDummyAuthContextValues({
@@ -763,7 +769,8 @@ test('can display a loading screen with a hook', async () => {
     const [showStill, setShowStill] = useState(false)
 
     useEffect(() => {
-      setTimeout(() => setShowStill(true), 100)
+      const timer = setTimeout(() => setShowStill(true), 100)
+      return () => clearTimeout(timer)
     }, [])
 
     return <>{showStill ? 'Still authenticating...' : 'Authenticating...'}</>